[GUACAMOLE-327] File upload/download issues in IE

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.9.12-incubating
• Component/s: guacamole-client
• Assignee: Mike Jumper
• Reporter: Shaun Tarves
• Created: 14/Jun/17 20:12
• Updated: 17/Jul/17 04:35
• Resolved: 17/Jul/17 04:35

Description

Internet Explorer, including 11, doesn't have support for location.origin so when trying to build the URL for the XMLHttpRequests in tunnelService.downloadStream and tunnelService.uploadToStream, the string "undefined" gets prepended onto the URL, rendering that functionality unusable.

The workaround/polyfill for this is pretty simple and well documented on the web and is basically:

if (!window.location.origin) {
  window.location.origin = window.location.protocol + '//' + window.location.hostname + (window.location.port ? (':' + window.location.port) : '');
}

reference: https://gist.github.com/hbogs/7908703

Additionally, IE seems to have a problem with the fallback code for removing the download iframe from the body. If the iframe is successfully removed by the callback of the iframe.onload handler, the stream.onend callback encounters an error because the iframe is no longer attached. A check for iframe's parentElement being defined is a workaround:

stream.onend = function downloadComplete() {
            $window.setTimeout(function cleanupIframe() {
                if (iframe.parentElement) {
                    document.body.removeChild(iframe);
                }
            }, DOWNLOAD_CLEANUP_WAIT);
        };

Finally, IE 10 and IE 11 are not able to download filetypes the browser will automatically try to open (like .txt and .jpg files). The download appears to just not do anything. The same remote system is able to download other extensions like .exe and .zip download just fine. This is true for either method (the menu file browser or the guacctl utility).

Issue Links

• duplicates: GUACAMOLE-347 IE may lack window.location.origin
• duplicates: GUACAMOLE-348 Stream download iframe may not exist in DOM at time of removal
• links to: location.origin is undefined in IE 11 on Windows 10 but works on Windows 7