Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-347

IE may lack window.location.origin

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.10-incubating, 0.9.11-incubating, 0.9.12-incubating, 0.9.13-incubating
    • Fix Version/s: 1.0.0
    • Component/s: None
    • Labels:
      None

      Description

      From GUACAMOLE-327:

      Internet Explorer, including 11, doesn't have support for location.origin so when trying to build the URL for the XMLHttpRequests in tunnelService.downloadStream and tunnelService.uploadToStream, the string "undefined" gets prepended onto the URL, rendering that functionality unusable.

      The workaround/polyfill for this is pretty simple and well documented on the web and is basically:

      if (!window.location.origin) {
        window.location.origin = window.location.protocol + '//' + window.location.hostname + (window.location.port ? (':' + window.location.port) : '');
      }
      

      In addition to the above, there are other locations within the Guacamole web application which use window.location.origin which will need to be corrected. In particular:

      • Reformatting of query parameters for AngularJS
      • Generation of share links
      • Generation of download/upload URLs for streams

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                vnick Nick Couchman
                Reporter:
                mjumper Mike Jumper
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: