[GUACAMOLE-347] IE may lack window.location.origin

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.10-incubating, 0.9.11-incubating, 0.9.12-incubating, 0.9.13-incubating
• Fix Version/s: 1.0.0
• Assignee: Nick Couchman
• Reporter: Mike Jumper
• Created: 17/Jul/17 04:27
• Updated: 14/Jan/18 03:54
• Resolved: 14/Jan/18 03:54

Description

From GUACAMOLE-327:

Internet Explorer, including 11, doesn't have support for location.origin so when trying to build the URL for the XMLHttpRequests in tunnelService.downloadStream and tunnelService.uploadToStream, the string "undefined" gets prepended onto the URL, rendering that functionality unusable.

The workaround/polyfill for this is pretty simple and well documented on the web and is basically:

if (!window.location.origin) {
  window.location.origin = window.location.protocol + '//' + window.location.hostname + (window.location.port ? (':' + window.location.port) : '');
}

In addition to the above, there are other locations within the Guacamole web application which use window.location.origin which will need to be corrected. In particular:

• Reformatting of query parameters for AngularJS
• Generation of share links
• Generation of download/upload URLs for streams

Issue Links

• is duplicated by: GUACAMOLE-327 File upload/download issues in IE
• relates to: GUACAMOLE-44 Upload/download of files that are more than 1 GB fail
• relates to: GUACAMOLE-5 Allow creation of per-connection share links
• relates to: GUACAMOLE-204 Support CAS Single Sign On
• links to: location.origin is undefined in IE 11 on Windows 10 but works on Windows 7