Uploaded image for project: 'Guacamole'
  1. Guacamole
  2. GUACAMOLE-348

Stream download iframe may not exist in DOM at time of removal

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.9.10-incubating, 0.9.11-incubating, 0.9.12-incubating
    • Fix Version/s: 1.0.0
    • Component/s: guacamole
    • Labels:
      None

      Description

      From GUACAMOLE-327:

      ... IE seems to have a problem with the fallback code for removing the download iframe from the body. If the iframe is successfully removed by the callback of the iframe.onload handler, the stream.onend callback encounters an error because the iframe is no longer attached. A check for iframe's parentElement being defined is a workaround:

      stream.onend = function downloadComplete() {
                  $window.setTimeout(function cleanupIframe() {
                      if (iframe.parentElement) {
                          document.body.removeChild(iframe);
                      }
                  }, DOWNLOAD_CLEANUP_WAIT);
              };
      

      In both the iframe's onload handler and the stream's onend handler, the iframe itself should only be removed from the DOM if it is actually present.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                james.muehlner James Muehlner
                Reporter:
                mjumper Mike Jumper
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: