[GUACAMOLE-348] Stream download iframe may not exist in DOM at time of removal

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.9.10-incubating, 0.9.11-incubating, 0.9.12-incubating
• Fix Version/s: 1.0.0
• Component/s: guacamole
• Assignee: James Muehlner
• Reporter: Mike Jumper
• Created: 17/Jul/17 04:27
• Updated: 07/Feb/18 05:04
• Resolved: 07/Feb/18 05:04

Description

From GUACAMOLE-327:

... IE seems to have a problem with the fallback code for removing the download iframe from the body. If the iframe is successfully removed by the callback of the iframe.onload handler, the stream.onend callback encounters an error because the iframe is no longer attached. A check for iframe's parentElement being defined is a workaround:

stream.onend = function downloadComplete() {
            $window.setTimeout(function cleanupIframe() {
                if (iframe.parentElement) {
                    document.body.removeChild(iframe);
                }
            }, DOWNLOAD_CLEANUP_WAIT);
        };

In both the iframe's onload handler and the stream's onend handler, the iframe itself should only be removed from the DOM if it is actually present.

Issue Links

• is duplicated by: GUACAMOLE-327 File upload/download issues in IE
• relates to: GUACAMOLE-105 File downloads may fail depending on timing