[GROOVY-5854] wasted work in the "ClassNode" constructor

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.5
• Fix Version/s: 2.0.6, 2.1.0-beta-1
• Flags: Patch
• Assignee: Jochen Theodorou
• Reporter: Adrian Nistor
• Created: 18/Dec/12 12:33
• Updated: 05/Apr/15 14:43
• Resolved: 19/Dec/12 09:56

Description

The problem appears in version 2.0.5 and in revision 4cf5263.. This
problem is similar to the previously fixed GROOVY-5803, GROOVY-5823,
GROOVY-5825, and GROOVY-5827. I attached a one-line patch that fixes
it. I will also post (in the "Comments" section) the URL for the
github pull request.

In the "ClassNode" constructor (the constructor with 5 parameters),
the loop over "interfaces" should break immediately after
"usesGenerics" is set to "true". All the iterations after
"usesGenerics" is set to "true" do not perform any useful work, at
best they just set "usesGenerics" again to "true".