[GROOVY-5825] wasted work in "ClassCompletionVerifier.addErrorIfParamsAndReturnTypeEqual"

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.0.5
• Fix Version/s: 2.0.6
• Flags: Patch
• Assignee: Jochen Theodorou
• Reporter: Adrian Nistor
• Created: 29/Nov/12 09:50
• Updated: 05/Apr/15 14:44
• Resolved: 30/Nov/12 12:38

Description

The problem appears in Groovy 2.0.5 and in revision 740ae7c.. I
attached a one-line patch (patch.diff) that fixes it.

In method
"ClassCompletionVerifier.addErrorIfParamsAndReturnTypeEqual", the loop
over "p1" and "p2" should break immediately after "isEqual" becomes
"false". All the iterations after "isEqual" is "false" do not perform
any useful work.