Uploaded image for project: 'Groovy'
  1. Groovy
  2. GROOVY-5827

wasted work in "StaticTypeCheckingVisitor.areCategoryMethodCalls"

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.0.5
    • 2.0.6
    • None
    • None
    • Patch

    Description

      The problem appears in Groovy 2.0.5 and in revision 740ae7c.. I
      attached a one-line patch that fixes it.

      In method "StaticTypeCheckingVisitor.areCategoryMethodCalls", the loop
      over "foundMethods" should break immediately after "category" is set
      to "false". All the iterations after "category" is set to "false" do
      not perform any useful work, at best they just set "category" again to
      "false".

      Attachments

        1. patch.diff
          0.8 kB

        Activity

          People

            blackdrag Jochen Theodorou
            adriannistor Adrian Nistor
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: