[FINERACT-922] Improve SchedulerJobHelper to be more reliable and prevent flaky tests

• Type: Improvement
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: Job Scheduler
• Assignee: Michael Vorburger
• Reporter: Michael Vorburger
• Created: 03/May/20 11:33
• Updated: 14/Jun/20 16:18
• Resolved: 14/Jun/20 16:18

Description

ptuomola pointed out in FINERACT-855 that the reason for at least some of our often Randomly Failing Integration Tests in FINERACT-850 is likely that the SchedulerJobHelper has serious issues.

Improving that helper presumably will help for a number of flaky tests.

Issue Links

• blocks: FINERACT-852 ArrayIndexOutOfBoundsException in ClientSavingsIntegrationTest and SchedulerJobsTest
• blocks: FINERACT-855 RecurringDepositTest.testRecurringDepositAccountWithClosureTypeTransferToSavings_WITH_HOLD_TAX
• blocks: FINERACT-850 Random Failing Integration Test
• blocks: FINERACT-923 SchedulerJobsTestResults.testApplyHolidaysToLoansJobOutcome Flaky Test Failed
• is blocked by: FINERACT-956 Logging missing / broken (since Spring Boot and/or Java 11 upgrade)
• is blocked by: FINERACT-958 Foreign key constraint fails (`fineract_default`.`m_savings_account_transaction`, CONSTRAINT `FK_m_savings_account_transaction_m_office` FOREIGN KEY (`office_id`) REFERENCES `m_office` (`id`))
• is blocked by: FINERACT-957 NullPointerException in SavingsAccount.office() and SavingsAccount.officeId()
• is blocked by: FINERACT-858 Errors (JobExecutionException) in Cron Jobs loose exception root cause details
• is blocked by: FINERACT-952 Remove un-used "Send messages to Email gateway" Job
• is blocked by: FINERACT-992 Field 'office_id' doesn't have a default value
• is blocked by: FINERACT-926 java.util.Date returned in ISO-8601 instant format ("2011-12-03T10:15:30Z") instead of as "May 3, 2020 10:51:19 PM"
• is blocked by: FINERACT-927 Travis CI should display more details for failing tests
• requires: FINERACT-950 FixedDepositTest > testFixedDepositAccountClosureTypeWithdrawal_WITH_HOLD_TAX() is flaky
• links to: GitHub Pull Request #811
• links to: GitHub Pull Request #812
• links to: GitHub Pull Request #813
• links to: GitHub Pull Request #814
• links to: GitHub Pull Request #817
• links to: GitHub Pull Request #821
• links to: GitHub Pull Request #852
• links to: GitHub Pull Request #966
• links to: GitHub Pull Request #999
• links to: GitHub Pull Request #1000