[FINERACT-957] NullPointerException in SavingsAccount.office() and SavingsAccount.officeId()

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Assignee: Michael Vorburger
• Reporter: Michael Vorburger
• Created: 09/May/20 01:30
• Updated: 09/May/20 11:34
• Resolved: 09/May/20 11:34

Description

While investigating FINERACT-922, and through FINERACT-858, I'm locally seeing the following errors when I run https://github.com/apache/fineract/pull/817 :

03:14:10.573 [Scheduler1group1_Worker-1] ERROR o.a.f.p.s.s.SavingsSchedularServiceImpl - Failed to post interest for Savings with id 1
java.lang.NullPointerException: null
        at org.apache.fineract.portfolio.savings.domain.SavingsAccount.officeId(SavingsAccount.java:1576)
        at org.apache.fineract.portfolio.savings.domain.SavingsAccount.deriveAccountingBridgeData(SavingsAccount.java:1486)
        at org.apache.fineract.portfolio.savings.service.SavingsAccountWritePlatformServiceJpaRepositoryImpl.postJournalEntries(SavingsAccountWritePlatformServiceJpaRepositoryImpl.java:1283)
        at org.apache.fineract.portfolio.savings.service.SavingsAccountWritePlatformServiceJpaRepositoryImpl.postInterest(SavingsAccountWritePlatformServiceJpaRepositoryImpl.java:568)

as well as (slightly different, note office() VS officeId()):

03:14:10.584 [Scheduler1group1_Worker-1] ERROR o.a.f.p.s.s.SavingsSchedularServiceImpl - Failed to post interest for Savings with id 8
java.lang.NullPointerException: null
        at org.apache.fineract.portfolio.savings.domain.SavingsAccount.office(SavingsAccount.java:1586)
        at org.apache.fineract.portfolio.savings.domain.SavingsAccount.postInterest(SavingsAccount.java:511)
        at org.apache.fineract.portfolio.savings.service.SavingsAccountWritePlatformServiceJpaRepositoryImpl.postInterest(SavingsAccountWritePlatformServiceJpaRepositoryImpl.java:556)
        at org.apache.fineract.portfolio.savings.service.SavingsAccountWritePlatformServiceJpaRepositoryImpl$$FastClassBySpringCGLIB$$fa18015c.invoke(<generated>)

Issue Links

• blocks: FINERACT-857 integrationtests.SchedulerJobsTestResults
• blocks: FINERACT-922 Improve SchedulerJobHelper to be more reliable and prevent flaky tests
• links to: GitHub Pull Request #854