[CASSANDRA-16095] When a table attempts to clean up metrics, it was cleaning up all global table metrics

• Type: Bug
• Status: Resolved
• Priority: Urgent
• Resolution: Fixed
• Fix Version/s: 4.0-beta4, 4.0
• Component/s: Observability/JMX
• Bug Category: Correctness - Unrecoverable Corruption / Loss
• Severity: Critical
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 4.0-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/c636d623a45daf69bdf4a1f6634524d7a1568b64

Test and Documentation Plan

added tests

• Assignee: David Capwell
• Reporter: Altan Özlü

Authors

David Capwell

Reviewers

Jon Meredith, Jordan West, Yifan Cai

• Created: 02/Sep/20 00:17
• Updated: 31/Oct/22 17:46
• Resolved: 02/Dec/20 23:20

Description

when i use

bin/nodetool tablestats xxxx

i get this error

error: org.apache.cassandra.metrics:type=Table,keyspace=xxxx,scope=feed,name=WriteLatency
-- StackTrace --
javax.management.InstanceNotFoundException: org.apache.cassandra.metrics:type=Table,keyspace=xxxx,scope=feed,name=WriteLatency

if i restart the node and check it works but if i write something then i get the error again

• Cassandra 4.0-beta1
• Ubuntu 20

Issue Links

• is duplicated by: CASSANDRA-16055 StorageService exposes ensureTraceKeyspace that is used by jvm-dtest, but it should be removed and use MigrationManager.evolveSystemKeyspace instead
• relates to: CASSANDRA-15582 4.0 quality testing: metrics
• links to: Circle CI: trunk
• links to: GH PR: trunk