[CALCITE-5990] Explicit cast to numeric type doesn't check overflow

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 1.35.0
• Fix Version/s: 1.36.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Mihai Budiu
• Reporter: Runkang He
• Created: 09/Sep/23 05:15
• Updated: 10/Nov/23 11:34
• Resolved: 01/Nov/23 00:16

Description

Explicit cast to numeric type doesn't check overflow, and this issue can be reproduced by sqlline:

select cast(empno as tinyint), cast(130 as tinyint) from emps where name='Alice'; -- empno is 130

The empno is INT type. The result is wrong:

-126, -126

I think it should throw exception when overflow, instead of returning wrong result to user.
At last, this issue was found when to turn on runtime check for CalciteSqlOperatorTest in CALCITE-5921.

Issue Links

• Blocked: CALCITE-5921 SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure
• is related to: CALCITE-5843 Constant expression with nested casts causes a compiler crash
• links to: GitHub Pull Request #3481