[CALCITE-5921] SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.35.0
• Fix Version/s: 1.36.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Runkang He
• Reporter: Runkang He
• Created: 13/Aug/23 07:55
• Updated: 10/Nov/23 11:34
• Resolved: 25/Oct/23 09:47

Description

SqlOperatorFixture.checkFails and checkAggFails don't check runtime failure. See more in code line. When the parameter `runtime` of SqlOperatorFixture.checkFails is true, it should execute the query and check runtime failure, but currently it ignores this, and only checks the parse and validation failure.
When fix this, there are 4 failed test cases in CalciteSqlOperatorTest.
At last, this issue was found when to implement `BIT_GET` function in CALCITE-5848.

Issue Links

• Blocked: CALCITE-5990 Explicit cast to numeric type doesn't check overflow
• is related to: CALCITE-2535 Runtime failure check not working in SqlTesterImpl.java
• is related to: CALCITE-4885 Fluent test fixtures so that dependent projects can write parser, validator and rules tests
• links to: GitHub Pull Request #3412
• links to: GitHub Pull Request #3471
• links to: GitHub Pull Request #3482