[CALCITE-5843] Constant expression with nested casts causes a compiler crash

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.34.0, 1.35.0
• Fix Version/s: 1.36.0
• Component/s: linq4j
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Mihai Budiu
• Created: 13/Jul/23 00:27
• Updated: 10/Nov/23 11:34
• Resolved: 11/Aug/23 19:17

Description

This program fails at compilation time:

SELECT CAST(CAST('32767.4' AS FLOAT) AS SMALLINT)

This happens in linq4j in Expressions.constant:

if ((clazz != Float.class && clazz != Double.class || !(value instanceof BigDecimal)) && !clazz.isInstance(value)) {
                String stringValue = String.valueOf(value);
                if (type == BigDecimal.class) {
                    value = new BigDecimal(stringValue);
                }

                if (type == BigInteger.class) {
                    value = new BigInteger(stringValue);
                }

                if (primitive != null) {
                    value = primitive.parse(stringValue);  // << error happens here
                }
            }

Issue Links

• relates to: CALCITE-5990 Explicit cast to numeric type doesn't check overflow
• links to: GitHub Pull Request #3314