[CALCITE-4159] RexSimplify should simplify more always true OR expressions

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.26.0
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Steven Talbot
• Created: 05/Aug/20 20:57
• Updated: 14/Jun/23 15:03
• Resolved: 21/Aug/20 06:34

Description

The following filters for a number are always true

x > 0 or x <= 0 or x is null
x < 0 or x >= 0 or x is null
x < 1 or x > 0 or x is null

where the 1/0 can be replaced by any number where the first is greater than the second

 

The following filter for a varchar is always true:

x LIKE '%' OR x is null

It would be nice if RexSimplify.simplifyOrTerms handled these cases.

Issue Links

• causes: CALCITE-4258 SqlToRelConverter: SELECT 1 IS [NOT] DISTINCT FROM NULL fails with AssertionError
• is related to: CALCITE-5780 Simplify '1 > x OR 1 <= x OR x IS NULL' to TRUE
• relates to: CALCITE-4190 OR simplification incorrectly loses term
• relates to: CALCITE-4155 Simplify IN expression of discrete values
• links to: GitHub Pull Request #2105