[CALCITE-4258] SqlToRelConverter: SELECT 1 IS [NOT] DISTINCT FROM NULL fails with AssertionError

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.26.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Ruben Q L
• Reporter: Ruben Q L
• Created: 15/Sep/20 09:17
• Updated: 06/Oct/20 17:17
• Resolved: 17/Sep/20 09:10

Description

Problem can be reproduced with the following tests (in core\src\test\resources\sql\misc.iq):

# [CALCITE-4258]
SELECT 1 IS DISTINCT FROM NULL;
+--------+
| EXPR$0 |
+--------+
| true   |
+--------+
(1 row)

!ok

# [CALCITE-4258]
SELECT 1 IS NOT DISTINCT FROM NULL;
+--------+
| EXPR$0 |
+--------+
| false  |
+--------+
(1 row)

!ok

These tests fail with:

> java.lang.AssertionError: Conversion to relational algebra failed to preserve datatypes:
> validated type:
> RecordType(BOOLEAN NOT NULL EXPR$0) NOT NULL
> converted type:
> RecordType(BOOLEAN EXPR$0) NOT NULL
> rel:
> LogicalProject(EXPR$0=[null:BOOLEAN])
>   LogicalValues(tuples=[[{ 0 }]])
44a47,109
> 	at org.apache.calcite.sql2rel.SqlToRelConverter.checkConvertedType(SqlToRelConverter.java:466)
> 	at org.apache.calcite.sql2rel.SqlToRelConverter.convertQuery(SqlToRelConverter.java:581)
> 	at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:242)
> 	at org.apache.calcite.prepare.Prepare.prepareSql(Prepare.java:208)
...

These queries used to work fine until recently, so this regression must have occurred not so long ago.

Issue Links

• is caused by: CALCITE-4159 RexSimplify should simplify more always true OR expressions
• links to: GitHub Pull Request #2152