[CALCITE-5780] Simplify '1 > x OR 1 <= x OR x IS NULL' to TRUE

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.34.0
• Fix Version/s: 1.35.0
• Component/s: core
• Labels: pull-request-available
• Assignee: Runkang He
• Reporter: Runkang He
• Created: 14/Jun/23 14:25
• Updated: 27/Jul/23 10:22
• Resolved: 06/Jul/23 23:23

Description

The following expressions which contain reverse order comparison are always true:

1 > x or 1 <= x or x is null
1 < x or 1 >= x or x is null
1 > x or 0 < x or x is null

But currently these expressions are not fully simplified to TRUE, the current simplified results are SEARCH operator.

The root cause is that RexSimplify doesn't identify these cases and makes targeted simplification.

It would be nice if RexSimplify.simplifyOr handled these cases.

Issue Links

• relates to: CALCITE-4159 RexSimplify should simplify more always true OR expressions
• relates to: CALCITE-5798 Improve simplification of '(x < y) IS NOT TRUE' when x and y are not nullable
• links to: GitHub Pull Request #3267