Details

    • Type: Sub-task Sub-task
    • Status: In Progress
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 1.6.0
    • Fix Version/s: 1.8.0
    • Component/s: build
    • Labels:
      None
    • Environment:

      IBM JVM

      Description

      There are a few issues, detailed below:

      a. The generated configuration files contain references to GC
      params that are specific to Sun JVM. In accumulo-env.sh, the
      ACCUMULO_TSERVER_OPTS contains -XX:NewSize and -XX:MaxNewSize , and also in ACCUMULO_GENERAL_OPTS,
      -XX:+UseConcMarkSweepGC -XX:CMSInitiatingOccupancyFraction=75 are used.

      b. in bin/accumulo, get ClassNotFoundException due to
      specification of JAXP Doc Builder:
      -Djavax.xml.parsers.DocumentBuilderFactory=com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderFactoryImpl
      .
      The Sun implementation of Document Builder Factory does not exists
      in IBM JDK, so a ClassNotFoundException is thrown on running accumulo
      script

      c. MiniAccumuloCluster - in the MiniAccumuloClusterImpl,
      Sun-speciifc GC params are passed as params to the java process (similar
      to section a. )

      Single proposal for solving all 3 issues:

      Enhance bootstrap_config.sh with request to select Java vendor.
      Selecting this will set correct values for GC params (they differ between
      IBM and Sun), inclusion/ommision of JAXP setting. The
      MiniAccumuloClusterImpl can read the same env variable that was set in
      code for the GC Params, and use in the exec command.

      For exampel, doing this will result in CMS settings existing for SUN JVM, but when using IBM JVM, the relevant GC parameter for IBM JVM will be used instead. In addition, the SUN JAXP implementation will be omitted on non-SUN JVM.

      For now, I plan on having 4 options in new question

      1. Sun
      2. OpenJDK
      3. IBM
      4. Other

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          13h 12m 1 Sean Busbey 24/Jun/14 21:23
          Patch Available Patch Available In Progress In Progress
          205d 17h 41m 1 Christopher Tubbs 16/Jan/15 14:04
          Josh Elser made changes -
          Fix Version/s 1.8.0 [ 12329879 ]
          Fix Version/s 1.7.0 [ 12324607 ]
          Christopher Tubbs made changes -
          Status Patch Available [ 10002 ] In Progress [ 3 ]
          Hide
          Christopher Tubbs added a comment -

          Marking as "In Progress", because the patch needs to be rebase'd onto master.

          Show
          Christopher Tubbs added a comment - Marking as "In Progress", because the patch needs to be rebase'd onto master.
          Christopher Tubbs made changes -
          Fix Version/s 1.6.3 [ 12329154 ]
          Hide
          Christopher Tubbs added a comment -

          No, it looks like the patch was never merged. It is no longer up-to-date either and cannot be merged cleanly. It needs to be re-based. Additionally, I think I'm going to drop the 1.6.x version from this, because it adds features (interactive menu options) to a script, and isn't just a bugfix. So, it should be rebase'd on master.

          Show
          Christopher Tubbs added a comment - No, it looks like the patch was never merged. It is no longer up-to-date either and cannot be merged cleanly. It needs to be re-based. Additionally, I think I'm going to drop the 1.6.x version from this, because it adds features (interactive menu options) to a script, and isn't just a bugfix. So, it should be rebase'd on master.
          Hide
          Corey J. Nolet added a comment -

          It looks like a pull request was merged in for this ticket. Can this be closed?

          Show
          Corey J. Nolet added a comment - It looks like a pull request was merged in for this ticket. Can this be closed?
          Corey J. Nolet made changes -
          Fix Version/s 1.6.3 [ 12329154 ]
          Fix Version/s 1.6.2 [ 12328644 ]
          Hide
          ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/accumulo/pull/9

          Show
          ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/accumulo/pull/9
          Corey J. Nolet made changes -
          Fix Version/s 1.6.2 [ 12328644 ]
          Corey J. Nolet made changes -
          Fix Version/s 1.6.1 [ 12325441 ]
          Hide
          ASF GitHub Bot added a comment -

          Github user haydenmarchant commented on the pull request:

          https://github.com/apache/accumulo/pull/9#issuecomment-48514562

          Please do. As you can see I am not just a newbie to accumulo

          sorry for the mess. (we accidentally removed the remote ACCUMULO-2944 branch while rebasing, so we had to reopen the pull request)

          Show
          ASF GitHub Bot added a comment - Github user haydenmarchant commented on the pull request: https://github.com/apache/accumulo/pull/9#issuecomment-48514562 Please do. As you can see I am not just a newbie to accumulo sorry for the mess. (we accidentally removed the remote ACCUMULO-2944 branch while rebasing, so we had to reopen the pull request)
          Hide
          ASF GitHub Bot added a comment -

          Github user busbey commented on the pull request:

          https://github.com/apache/accumulo/pull/9#issuecomment-48513357

          something has gone wrong in the rebase, since git now thinks all ~1750 commits are a part of the merge.

          would you mind if I just picked off your commit and did the cleanup to make it work on the current dev branch?

          Show
          ASF GitHub Bot added a comment - Github user busbey commented on the pull request: https://github.com/apache/accumulo/pull/9#issuecomment-48513357 something has gone wrong in the rebase, since git now thinks all ~1750 commits are a part of the merge. would you mind if I just picked off your commit and did the cleanup to make it work on the current dev branch?
          Hide
          ASF GitHub Bot added a comment -

          Github user haydenmarchant commented on the pull request:

          https://github.com/apache/accumulo/pull/9#issuecomment-48513244

          I rebased and changed the commit message. Please let me know that all of this is ok.

          Show
          ASF GitHub Bot added a comment - Github user haydenmarchant commented on the pull request: https://github.com/apache/accumulo/pull/9#issuecomment-48513244 I rebased and changed the commit message. Please let me know that all of this is ok.
          Hide
          ASF GitHub Bot added a comment -

          GitHub user haydenmarchant reopened a pull request:

          https://github.com/apache/accumulo/pull/9

          ACCUMULO-2944 Fixes harded coded Sun JVM in config and env

          ACCUMULO-2944 add support for multiple java vendors in conf & scripts

          Support for multiple java vendors is added by getting the
          bootstrap_config.sh to generate correct configuration depending on
          specified java vendor. Following details depend on Java vendor

          • GC settings
          • Exclude/Include JAXP implementation
          • Default NRG provider

          A new question is being asked in the bootstrap_config.sh for Java
          vendor. This is then used to set GC settings, exclude/include JAXP
          implementation in ACCUMULO_OPTS. Also, default NRG provider is being
          injected as system property on command line since IBM JVM does not
          have SUN registered as default provider.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/haydenmarchant/accumulo ACCUMULO-2944

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/accumulo/pull/9.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #9


          commit a20e19fc4f7c7989ba1b50459d9f762063e3e631
          Author: Christopher Tubbs <ctubbsii@apache.org>
          Date: 2014-03-28T00:35:32Z

          ACCUMULO-1487, ACCUMULO-1491 Stop packaging docs for monitor

          Moved docs out of monitor and into docs directory. Added docs to assemblies.
          Remove unnecessary goals from release profile. Remove links from docs to
          apidocs. Restricted rpms/debs from being placed in lib/ and docs/ in tarball.

          commit e5070d0ad084f218d283b9daa58246184afdb477
          Author: Eric C. Newton <eric.newton@gmail.com>
          Date: 2014-03-28T16:58:19Z

          ACCUMULO-2455 1s timeout is too tight for testing

          commit d2089c898c64ce2ac6588b9052505dc4c49d971f
          Author: Bill Havanki <bhavanki@cloudera.com>
          Date: 2014-03-13T20:34:55Z

          ACCUMULO-2470 Unit tests for server/base module

          This commit adds unit tests to code under the server/base module. It also includes changes
          to o.a.a.server.problems.ProblemReport to enable comprehensive testing.

          commit 3354b92af1820ca12c9dbe5dc4d0db7d8d0a640a
          Author: Mike Drob <mdrob@cloudera.com>
          Date: 2014-03-28T21:24:33Z

          Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT

          commit 9843911d939bafc2808f3edb30903881cb7fa04d
          Author: Mike Drob <mdrob@cloudera.com>
          Date: 2014-03-29T04:49:59Z

          Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT

          commit f4a9626a5a5e2a66c201218b13aeef558b63506c
          Author: Christopher Tubbs <ctubbsii@apache.org>
          Date: 2014-03-31T17:40:35Z

          ACCUMULO-1996 Add some javadocs to SimpleMacIT to define its scope

          commit dda2fb06ba6452d5af6bda3809684ec2f3413022
          Author: Christopher Tubbs <ctubbsii@apache.org>
          Date: 2014-03-31T18:11:36Z

          ACCUMULO-2392 Log the MAC directory used by a test

          Add a log message to SimpleMacIT to inform which MiniAccumuloCluster instance is
          in use for each SimpleMacIT test, to make it easier to debug a failed test.

          Additionally, renamed a trivial helper method to more accurately reflect its
          purpose.

          commit fff852fce6d971e7e76c91ae911fbfca2e26426b
          Author: Christopher Tubbs <ctubbsii@apache.org>
          Date: 2014-03-31T18:40:26Z

          ACCUMULO-2470 Clean up warnings introduced by previous commit

          (Unused fields and imports)

          commit 67c15ffa24d2515e5e39562d2128e96094598492
          Author: Christopher Tubbs <ctubbsii@apache.org>
          Date: 2014-03-31T19:36:49Z

          ACCUMULO-2595 Remove jar for init module

          commit 4a77566a314aaa6c2086d8d07d228a073a437777
          Author: Christopher Tubbs <ctubbsii@apache.org>
          Date: 2014-03-31T19:46:08Z

          ACCUMULO-2595 Remove dep. mgmt entry for accumulo-init jar

          commit 4956b15a6f86bca303074b907b2e62f783d395bf
          Author: Eric C. Newton <eric.newton@gmail.com>
          Date: 2014-04-01T15:45:28Z

          ACCUMULO-2601 remove initialization from rpm

          commit 7a68838ac5650dbc1bfe64818506875c4dacc099
          Author: Eric C. Newton <eric.newton@gmail.com>
          Date: 2014-04-01T17:50:07Z

          ACCUMULO-2601 test for the existence of /accumulo in hdfs

          commit 7ac4b54a76b85314a483378e01980c73f891a900
          Author: Eric C. Newton <eric.newton@gmail.com>
          Date: 2014-04-01T18:46:17Z

          ACCUMULO-2605 list slf4j as a test dependency

          commit 3a1b38719c69d34abb27e181fce3bfdb7758bf92
          Author: Josh Elser <elserj@apache.org>
          Date: 2014-03-26T22:04:05Z

          ACCUMULO-2592 Create AccumuloCluster and AccumuloConfig interfaces to allow for proper non-minicluster implementations.

          Includes package-level javadocs in lieu of some specific annotation specifying api "experimental" status.

          commit 86cafd972793330026c6e4739a2a94320608a333
          Author: Josh Elser <elserj@apache.org>
          Date: 2014-04-01T21:08:00Z

          Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT

          Conflicts:
          core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java
          core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java

          commit a1814fc0dbdf0fb095ad87385dfb133c5a1f35df
          Author: Christopher Tubbs <ctubbsii@apache.org>
          Date: 2014-04-01T21:48:12Z

          ACCUMULO-2606 Remove system-level packaging stuff

          Removing RPM/DEB build tasks and maven profiles, related documentation,
          and system-specific packaging resources and scripts, in order to defer such
          things to downstream package maintainers.

          commit d896bf37d2dcf1834e32425b7364e6d5963e4c12
          Author: Sean Busbey <busbey@cloudera.com>
          Date: 2014-03-28T21:47:00Z

          ACCUMULO-2590 Updates our Public API declaration to be more explicit.

          commit 09388f5671a3979c3c83c5de8f63eb55a3e83fcb
          Author: Eric C. Newton <eric.newton@gmail.com>
          Date: 2014-04-02T15:02:37Z

          ACCUMULO-2584 use IteratorSettings to push the scan iterator, not a zookeeper setting

          commit e2552a89f4436292817e1bf94aa0cfa4f7e88339
          Author: Josh Elser <elserj@apache.org>
          Date: 2014-04-02T18:42:39Z

          ACCUMULO-2592 Fix incorrect javadoc

          commit aaa8afb9fe28d6af3437428dc30490fc079f2836
          Author: Christopher Tubbs <ctubbsii@apache.org>
          Date: 2014-04-02T20:24:11Z

          ACCUMULO-2616 Bump maven plugin/parent POM versions

          Change Apache parent POM to version 14. Drop resulting redundant and/or
          unnecessary plugin versions, configuration, and properties.

          Update bouncycastle test dependency version and incorporate into the
          dependencyManagement section and fix resulting deprecation warnings.

          Drop redundant m2e container in assembly POM. Migrate to non-deprecated
          surefire/failsafe fork settings. Update other plugin versions to latest.

          commit 2c1454e73f50a1e5fa2183deb193f58d6a8337a8
          Author: Christopher Tubbs <ctubbsii@apache.org>
          Date: 2014-04-03T15:11:50Z

          ACCUMULO-2620 Make table names more unique and cleanup unused field.

          Support parallel tests better with more better uniqueness in table names.

          commit b3f6e0f8f6dda80f98c5b031baaec7061cecf0c5
          Author: Mike Drob <mdrob@cloudera.com>
          Date: 2014-04-04T01:57:01Z

          Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT

          commit 6960570252751a6a2fcda6da19755462405f6116
          Author: Josh Elser <elserj@apache.org>
          Date: 2014-04-04T16:32:24Z

          Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT

          commit d137a4f9e49ca05c4967ac3ed09ba3e3206b2ec6
          Author: jpmcnamee <jpm34@terpmail.umd.edu>
          Date: 2014-03-06T20:34:14Z

          ACCUMULO-1395 Generate example configuration

          Signed-off-by: Christopher Tubbs <ctubbsii@apache.org>

          commit 527913a317eaff502cbf16a8cc8aba810bb20b0a
          Author: John Vines <vines@apache.org>
          Date: 2014-04-04T18:58:21Z

          Revert "ACCUMULO-1395 Generate example configuration"

          This reverts commit d137a4f9e49ca05c4967ac3ed09ba3e3206b2ec6.

          commit 902446659c2d030d787f2c92138afa305d05248d
          Author: Josh Elser <elserj@apache.org>
          Date: 2014-04-04T20:33:11Z

          Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT

          Conflicts:
          test/src/test/java/org/apache/accumulo/test/ShellServerTest.java

          commit c60e3e593809b67b194a4e377e03bdcdb5c8e844
          Author: Mike Drob <mdrob@cloudera.com>
          Date: 2014-04-04T23:16:20Z

          Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT (-sours)

          commit 2cb526e5e11a54e6e1932cf37fa715b2cae22533
          Author: Christopher Tubbs <ctubbsii@apache.org>
          Date: 2014-04-04T23:55:25Z

          ACCUMULO-2455 Remove JVM reuse, causing some test failures

          Forked JVMs are reused, but a JVM can be left in a bad state, causing
          a cascade of other test failures. This reuse can speed up the tests,
          but I'm disabling it, until we can figure out which tests leave the
          JVM in a bad (non-reusable) state and whether we can actually avoid
          that or not, such that it'd be safe to turn JVM reuse back on.

          commit 957c9d1b34afb8a5b7347921ba2d5b0b22bbc828
          Author: Sean Busbey <busbey@cloudera.com>
          Date: 2014-04-05T00:27:39Z

          Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT

          Conflicts:
          fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java
          fate/src/main/java/org/apache/accumulo/fate/TStore.java
          server/base/src/main/java/org/apache/accumulo/server/Accumulo.java
          server/src/main/java/org/apache/accumulo/server/master/Master.java
          server/src/main/java/org/apache/accumulo/server/util/MetadataTable.java
          server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java

          commit e4aa11e1b1a046dec9116273eb57f053aa68fd3f
          Author: Sean Busbey <busbey@cloudera.com>
          Date: 2014-04-04T08:35:01Z

          ACCUMULO-2519 Updates Classes added in 1.6.0 for read only fate changes.


          Show
          ASF GitHub Bot added a comment - GitHub user haydenmarchant reopened a pull request: https://github.com/apache/accumulo/pull/9 ACCUMULO-2944 Fixes harded coded Sun JVM in config and env ACCUMULO-2944 add support for multiple java vendors in conf & scripts Support for multiple java vendors is added by getting the bootstrap_config.sh to generate correct configuration depending on specified java vendor. Following details depend on Java vendor GC settings Exclude/Include JAXP implementation Default NRG provider A new question is being asked in the bootstrap_config.sh for Java vendor. This is then used to set GC settings, exclude/include JAXP implementation in ACCUMULO_OPTS. Also, default NRG provider is being injected as system property on command line since IBM JVM does not have SUN registered as default provider. You can merge this pull request into a Git repository by running: $ git pull https://github.com/haydenmarchant/accumulo ACCUMULO-2944 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/accumulo/pull/9.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #9 commit a20e19fc4f7c7989ba1b50459d9f762063e3e631 Author: Christopher Tubbs <ctubbsii@apache.org> Date: 2014-03-28T00:35:32Z ACCUMULO-1487 , ACCUMULO-1491 Stop packaging docs for monitor Moved docs out of monitor and into docs directory. Added docs to assemblies. Remove unnecessary goals from release profile. Remove links from docs to apidocs. Restricted rpms/debs from being placed in lib/ and docs/ in tarball. commit e5070d0ad084f218d283b9daa58246184afdb477 Author: Eric C. Newton <eric.newton@gmail.com> Date: 2014-03-28T16:58:19Z ACCUMULO-2455 1s timeout is too tight for testing commit d2089c898c64ce2ac6588b9052505dc4c49d971f Author: Bill Havanki <bhavanki@cloudera.com> Date: 2014-03-13T20:34:55Z ACCUMULO-2470 Unit tests for server/base module This commit adds unit tests to code under the server/base module. It also includes changes to o.a.a.server.problems.ProblemReport to enable comprehensive testing. commit 3354b92af1820ca12c9dbe5dc4d0db7d8d0a640a Author: Mike Drob <mdrob@cloudera.com> Date: 2014-03-28T21:24:33Z Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT commit 9843911d939bafc2808f3edb30903881cb7fa04d Author: Mike Drob <mdrob@cloudera.com> Date: 2014-03-29T04:49:59Z Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT commit f4a9626a5a5e2a66c201218b13aeef558b63506c Author: Christopher Tubbs <ctubbsii@apache.org> Date: 2014-03-31T17:40:35Z ACCUMULO-1996 Add some javadocs to SimpleMacIT to define its scope commit dda2fb06ba6452d5af6bda3809684ec2f3413022 Author: Christopher Tubbs <ctubbsii@apache.org> Date: 2014-03-31T18:11:36Z ACCUMULO-2392 Log the MAC directory used by a test Add a log message to SimpleMacIT to inform which MiniAccumuloCluster instance is in use for each SimpleMacIT test, to make it easier to debug a failed test. Additionally, renamed a trivial helper method to more accurately reflect its purpose. commit fff852fce6d971e7e76c91ae911fbfca2e26426b Author: Christopher Tubbs <ctubbsii@apache.org> Date: 2014-03-31T18:40:26Z ACCUMULO-2470 Clean up warnings introduced by previous commit (Unused fields and imports) commit 67c15ffa24d2515e5e39562d2128e96094598492 Author: Christopher Tubbs <ctubbsii@apache.org> Date: 2014-03-31T19:36:49Z ACCUMULO-2595 Remove jar for init module commit 4a77566a314aaa6c2086d8d07d228a073a437777 Author: Christopher Tubbs <ctubbsii@apache.org> Date: 2014-03-31T19:46:08Z ACCUMULO-2595 Remove dep. mgmt entry for accumulo-init jar commit 4956b15a6f86bca303074b907b2e62f783d395bf Author: Eric C. Newton <eric.newton@gmail.com> Date: 2014-04-01T15:45:28Z ACCUMULO-2601 remove initialization from rpm commit 7a68838ac5650dbc1bfe64818506875c4dacc099 Author: Eric C. Newton <eric.newton@gmail.com> Date: 2014-04-01T17:50:07Z ACCUMULO-2601 test for the existence of /accumulo in hdfs commit 7ac4b54a76b85314a483378e01980c73f891a900 Author: Eric C. Newton <eric.newton@gmail.com> Date: 2014-04-01T18:46:17Z ACCUMULO-2605 list slf4j as a test dependency commit 3a1b38719c69d34abb27e181fce3bfdb7758bf92 Author: Josh Elser <elserj@apache.org> Date: 2014-03-26T22:04:05Z ACCUMULO-2592 Create AccumuloCluster and AccumuloConfig interfaces to allow for proper non-minicluster implementations. Includes package-level javadocs in lieu of some specific annotation specifying api "experimental" status. commit 86cafd972793330026c6e4739a2a94320608a333 Author: Josh Elser <elserj@apache.org> Date: 2014-04-01T21:08:00Z Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT Conflicts: core/src/main/java/org/apache/accumulo/core/client/mapred/InputFormatBase.java core/src/main/java/org/apache/accumulo/core/client/mapreduce/InputFormatBase.java commit a1814fc0dbdf0fb095ad87385dfb133c5a1f35df Author: Christopher Tubbs <ctubbsii@apache.org> Date: 2014-04-01T21:48:12Z ACCUMULO-2606 Remove system-level packaging stuff Removing RPM/DEB build tasks and maven profiles, related documentation, and system-specific packaging resources and scripts, in order to defer such things to downstream package maintainers. commit d896bf37d2dcf1834e32425b7364e6d5963e4c12 Author: Sean Busbey <busbey@cloudera.com> Date: 2014-03-28T21:47:00Z ACCUMULO-2590 Updates our Public API declaration to be more explicit. commit 09388f5671a3979c3c83c5de8f63eb55a3e83fcb Author: Eric C. Newton <eric.newton@gmail.com> Date: 2014-04-02T15:02:37Z ACCUMULO-2584 use IteratorSettings to push the scan iterator, not a zookeeper setting commit e2552a89f4436292817e1bf94aa0cfa4f7e88339 Author: Josh Elser <elserj@apache.org> Date: 2014-04-02T18:42:39Z ACCUMULO-2592 Fix incorrect javadoc commit aaa8afb9fe28d6af3437428dc30490fc079f2836 Author: Christopher Tubbs <ctubbsii@apache.org> Date: 2014-04-02T20:24:11Z ACCUMULO-2616 Bump maven plugin/parent POM versions Change Apache parent POM to version 14. Drop resulting redundant and/or unnecessary plugin versions, configuration, and properties. Update bouncycastle test dependency version and incorporate into the dependencyManagement section and fix resulting deprecation warnings. Drop redundant m2e container in assembly POM. Migrate to non-deprecated surefire/failsafe fork settings. Update other plugin versions to latest. commit 2c1454e73f50a1e5fa2183deb193f58d6a8337a8 Author: Christopher Tubbs <ctubbsii@apache.org> Date: 2014-04-03T15:11:50Z ACCUMULO-2620 Make table names more unique and cleanup unused field. Support parallel tests better with more better uniqueness in table names. commit b3f6e0f8f6dda80f98c5b031baaec7061cecf0c5 Author: Mike Drob <mdrob@cloudera.com> Date: 2014-04-04T01:57:01Z Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT commit 6960570252751a6a2fcda6da19755462405f6116 Author: Josh Elser <elserj@apache.org> Date: 2014-04-04T16:32:24Z Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT commit d137a4f9e49ca05c4967ac3ed09ba3e3206b2ec6 Author: jpmcnamee <jpm34@terpmail.umd.edu> Date: 2014-03-06T20:34:14Z ACCUMULO-1395 Generate example configuration Signed-off-by: Christopher Tubbs <ctubbsii@apache.org> commit 527913a317eaff502cbf16a8cc8aba810bb20b0a Author: John Vines <vines@apache.org> Date: 2014-04-04T18:58:21Z Revert " ACCUMULO-1395 Generate example configuration" This reverts commit d137a4f9e49ca05c4967ac3ed09ba3e3206b2ec6. commit 902446659c2d030d787f2c92138afa305d05248d Author: Josh Elser <elserj@apache.org> Date: 2014-04-04T20:33:11Z Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT Conflicts: test/src/test/java/org/apache/accumulo/test/ShellServerTest.java commit c60e3e593809b67b194a4e377e03bdcdb5c8e844 Author: Mike Drob <mdrob@cloudera.com> Date: 2014-04-04T23:16:20Z Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT (-sours) commit 2cb526e5e11a54e6e1932cf37fa715b2cae22533 Author: Christopher Tubbs <ctubbsii@apache.org> Date: 2014-04-04T23:55:25Z ACCUMULO-2455 Remove JVM reuse, causing some test failures Forked JVMs are reused, but a JVM can be left in a bad state, causing a cascade of other test failures. This reuse can speed up the tests, but I'm disabling it, until we can figure out which tests leave the JVM in a bad (non-reusable) state and whether we can actually avoid that or not, such that it'd be safe to turn JVM reuse back on. commit 957c9d1b34afb8a5b7347921ba2d5b0b22bbc828 Author: Sean Busbey <busbey@cloudera.com> Date: 2014-04-05T00:27:39Z Merge branch '1.5.2-SNAPSHOT' into 1.6.0-SNAPSHOT Conflicts: fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java fate/src/main/java/org/apache/accumulo/fate/TStore.java server/base/src/main/java/org/apache/accumulo/server/Accumulo.java server/src/main/java/org/apache/accumulo/server/master/Master.java server/src/main/java/org/apache/accumulo/server/util/MetadataTable.java server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java commit e4aa11e1b1a046dec9116273eb57f053aa68fd3f Author: Sean Busbey <busbey@cloudera.com> Date: 2014-04-04T08:35:01Z ACCUMULO-2519 Updates Classes added in 1.6.0 for read only fate changes.
          Hide
          ASF GitHub Bot added a comment -

          Github user haydenmarchant closed the pull request at:

          https://github.com/apache/accumulo/pull/9

          Show
          ASF GitHub Bot added a comment - Github user haydenmarchant closed the pull request at: https://github.com/apache/accumulo/pull/9
          Hide
          ASF GitHub Bot added a comment -

          Github user busbey commented on a diff in the pull request:

          https://github.com/apache/accumulo/pull/9#discussion_r14696949

          — Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java —
          @@ -259,7 +259,14 @@ private Process _exec(Class<?> clazz, List<String> extraJvmOpts, String... args)
          for (Entry<String,String> sysProp : config.getSystemProperties().entrySet())

          { argList.add(String.format("-D%s=%s", sysProp.getKey(), sysProp.getValue())); }
          • argList.addAll(Arrays.asList("-XX:+UseConcMarkSweepGC", "-XX:CMSInitiatingOccupancyFraction=75", "-Dapple.awt.UIElement=true", Main.class.getName(), className));
            +
            + String gcPolicyArgs = System.getenv("GC_POLICY_ARGS");
              • End diff –

          so long as there's a ticket filed, I'd be fine with the maven profile going into a follow on.

          Show
          ASF GitHub Bot added a comment - Github user busbey commented on a diff in the pull request: https://github.com/apache/accumulo/pull/9#discussion_r14696949 — Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java — @@ -259,7 +259,14 @@ private Process _exec(Class<?> clazz, List<String> extraJvmOpts, String... args) for (Entry<String,String> sysProp : config.getSystemProperties().entrySet()) { argList.add(String.format("-D%s=%s", sysProp.getKey(), sysProp.getValue())); } argList.addAll(Arrays.asList("-XX:+UseConcMarkSweepGC", "-XX:CMSInitiatingOccupancyFraction=75", "-Dapple.awt.UIElement=true", Main.class.getName(), className)); + + String gcPolicyArgs = System.getenv("GC_POLICY_ARGS"); End diff – so long as there's a ticket filed, I'd be fine with the maven profile going into a follow on.
          Hide
          ASF GitHub Bot added a comment -

          Github user haydenmarchant commented on a diff in the pull request:

          https://github.com/apache/accumulo/pull/9#discussion_r14696336

          — Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java —
          @@ -259,7 +259,14 @@ private Process _exec(Class<?> clazz, List<String> extraJvmOpts, String... args)
          for (Entry<String,String> sysProp : config.getSystemProperties().entrySet())

          { argList.add(String.format("-D%s=%s", sysProp.getKey(), sysProp.getValue())); }
          • argList.addAll(Arrays.asList("-XX:+UseConcMarkSweepGC", "-XX:CMSInitiatingOccupancyFraction=75", "-Dapple.awt.UIElement=true", Main.class.getName(), className));
            +
            + String gcPolicyArgs = System.getenv("GC_POLICY_ARGS");
              • End diff –

          Since I am not so familiar with maven, my assumption was that a user would manually change the pom to 'inject' the JVM-vendor. If we can automate this by profiles, that makes a lot of sense. I take it that it doesn't change this patch, but rather would be on top of this?

          Show
          ASF GitHub Bot added a comment - Github user haydenmarchant commented on a diff in the pull request: https://github.com/apache/accumulo/pull/9#discussion_r14696336 — Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java — @@ -259,7 +259,14 @@ private Process _exec(Class<?> clazz, List<String> extraJvmOpts, String... args) for (Entry<String,String> sysProp : config.getSystemProperties().entrySet()) { argList.add(String.format("-D%s=%s", sysProp.getKey(), sysProp.getValue())); } argList.addAll(Arrays.asList("-XX:+UseConcMarkSweepGC", "-XX:CMSInitiatingOccupancyFraction=75", "-Dapple.awt.UIElement=true", Main.class.getName(), className)); + + String gcPolicyArgs = System.getenv("GC_POLICY_ARGS"); End diff – Since I am not so familiar with maven, my assumption was that a user would manually change the pom to 'inject' the JVM-vendor. If we can automate this by profiles, that makes a lot of sense. I take it that it doesn't change this patch, but rather would be on top of this?
          Hide
          ASF GitHub Bot added a comment -

          Github user busbey commented on the pull request:

          https://github.com/apache/accumulo/pull/9#issuecomment-48436920

          Overall patch is looking good. Could you rebase onto the current 1.6.1-SNAPSHOT and resolved the conflict?

          The commit message still doesn't start with the jira reference. Could you move it to the beginning of the summary line?

          Show
          ASF GitHub Bot added a comment - Github user busbey commented on the pull request: https://github.com/apache/accumulo/pull/9#issuecomment-48436920 Overall patch is looking good. Could you rebase onto the current 1.6.1-SNAPSHOT and resolved the conflict? The commit message still doesn't start with the jira reference. Could you move it to the beginning of the summary line?
          Hide
          ASF GitHub Bot added a comment -

          Github user busbey commented on a diff in the pull request:

          https://github.com/apache/accumulo/pull/9#discussion_r14696044

          — Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java —
          @@ -259,7 +259,14 @@ private Process _exec(Class<?> clazz, List<String> extraJvmOpts, String... args)
          for (Entry<String,String> sysProp : config.getSystemProperties().entrySet())

          { argList.add(String.format("-D%s=%s", sysProp.getKey(), sysProp.getValue())); }
          • argList.addAll(Arrays.asList("-XX:+UseConcMarkSweepGC", "-XX:CMSInitiatingOccupancyFraction=75", "-Dapple.awt.UIElement=true", Main.class.getName(), className));
            +
            + String gcPolicyArgs = System.getenv("GC_POLICY_ARGS");
              • End diff –

          For this to impact the current MAC uses in the ITs, won't we need to have this env variable set? should we be adding jvm-vendor activated profiles to the pom?

          Show
          ASF GitHub Bot added a comment - Github user busbey commented on a diff in the pull request: https://github.com/apache/accumulo/pull/9#discussion_r14696044 — Diff: minicluster/src/main/java/org/apache/accumulo/minicluster/impl/MiniAccumuloClusterImpl.java — @@ -259,7 +259,14 @@ private Process _exec(Class<?> clazz, List<String> extraJvmOpts, String... args) for (Entry<String,String> sysProp : config.getSystemProperties().entrySet()) { argList.add(String.format("-D%s=%s", sysProp.getKey(), sysProp.getValue())); } argList.addAll(Arrays.asList("-XX:+UseConcMarkSweepGC", "-XX:CMSInitiatingOccupancyFraction=75", "-Dapple.awt.UIElement=true", Main.class.getName(), className)); + + String gcPolicyArgs = System.getenv("GC_POLICY_ARGS"); End diff – For this to impact the current MAC uses in the ITs, won't we need to have this env variable set? should we be adding jvm-vendor activated profiles to the pom?
          Hide
          ASF GitHub Bot added a comment -

          Github user haydenmarchant commented on the pull request:

          https://github.com/apache/accumulo/pull/9#issuecomment-48433782

          MiniAccumuloClusterImpl is now in patch.

          Show
          ASF GitHub Bot added a comment - Github user haydenmarchant commented on the pull request: https://github.com/apache/accumulo/pull/9#issuecomment-48433782 MiniAccumuloClusterImpl is now in patch.
          Hide
          ASF GitHub Bot added a comment -

          Github user busbey commented on a diff in the pull request:

          https://github.com/apache/accumulo/pull/9#discussion_r14422863

          — Diff: conf/templates/accumulo-env.sh —
          @@ -51,10 +51,11 @@ test -z "$ACCUMULO_TSERVER_OPTS" && export ACCUMULO_TSERVER_OPTS="$

          {POLICY} ${tS
          test -z "$ACCUMULO_MASTER_OPTS" && export ACCUMULO_MASTER_OPTS="${POLICY}

          $

          {masterHigh_masterLow}

          "
          test -z "$ACCUMULO_MONITOR_OPTS" && export ACCUMULO_MONITOR_OPTS="$

          {POLICY}

          $

          {monitorHigh_monitorLow}

          "
          test -z "$ACCUMULO_GC_OPTS" && export ACCUMULO_GC_OPTS="$

          {gcHigh_gcLow}

          "
          -test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="-XX:+UseConcMarkSweepGC -XX:CMSInitiatingOccupancyFraction=75 -Djava.net.preferIPv4Stack=true"
          +test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="$

          {gcPolicy} -Djava.net.preferIPv4Stack=true ${jaxpDocBuilderFactory} ${randomNumGeneratorProviderOverride}"
          test -z "$ACCUMULO_OTHER_OPTS" && export ACCUMULO_OTHER_OPTS="${otherHigh_otherLow}"
          # what do when the JVM runs out of heap memory
          export ACCUMULO_KILL_CMD='kill -9 %p'
          +export GC_POLICY_ARGS="${gcPolicy}

          "
          — End diff –

          Yes, that sounds like a god idea.

          please either include the MiniAccumuloCluster change in this same patch, or move this environment variable to the patch taht includes said changes.

          Show
          ASF GitHub Bot added a comment - Github user busbey commented on a diff in the pull request: https://github.com/apache/accumulo/pull/9#discussion_r14422863 — Diff: conf/templates/accumulo-env.sh — @@ -51,10 +51,11 @@ test -z "$ACCUMULO_TSERVER_OPTS" && export ACCUMULO_TSERVER_OPTS="$ {POLICY} ${tS test -z "$ACCUMULO_MASTER_OPTS" && export ACCUMULO_MASTER_OPTS="${POLICY} $ {masterHigh_masterLow} " test -z "$ACCUMULO_MONITOR_OPTS" && export ACCUMULO_MONITOR_OPTS="$ {POLICY} $ {monitorHigh_monitorLow} " test -z "$ACCUMULO_GC_OPTS" && export ACCUMULO_GC_OPTS="$ {gcHigh_gcLow} " -test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="-XX:+UseConcMarkSweepGC -XX:CMSInitiatingOccupancyFraction=75 -Djava.net.preferIPv4Stack=true" +test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="$ {gcPolicy} -Djava.net.preferIPv4Stack=true ${jaxpDocBuilderFactory} ${randomNumGeneratorProviderOverride}" test -z "$ACCUMULO_OTHER_OPTS" && export ACCUMULO_OTHER_OPTS="${otherHigh_otherLow}" # what do when the JVM runs out of heap memory export ACCUMULO_KILL_CMD='kill -9 %p' +export GC_POLICY_ARGS="${gcPolicy} " — End diff – Yes, that sounds like a god idea. please either include the MiniAccumuloCluster change in this same patch, or move this environment variable to the patch taht includes said changes.
          Hide
          ASF GitHub Bot added a comment -

          Github user busbey commented on the pull request:

          https://github.com/apache/accumulo/pull/9#issuecomment-47695850

          The commit message should start with the jira and a short summary.

          e.g.

          > ACCUMULO-2944 add support for multiple java vendors in conf & scripts.
          >
          > A new question is being asked in the bootstrap_config.sh for Java vendor. This is then used to set
          > GC settings, exclude/include JAXP implementation in ACCUMULO_OPTS. Also, default NRG
          > provider is being injected as system property on command line since IBM JVM does not have SUN
          > registered as default provider.

          Show
          ASF GitHub Bot added a comment - Github user busbey commented on the pull request: https://github.com/apache/accumulo/pull/9#issuecomment-47695850 The commit message should start with the jira and a short summary. e.g. > ACCUMULO-2944 add support for multiple java vendors in conf & scripts. > > A new question is being asked in the bootstrap_config.sh for Java vendor. This is then used to set > GC settings, exclude/include JAXP implementation in ACCUMULO_OPTS. Also, default NRG > provider is being injected as system property on command line since IBM JVM does not have SUN > registered as default provider.
          Hide
          ASF GitHub Bot added a comment -

          Github user haydenmarchant commented on the pull request:

          https://github.com/apache/accumulo/pull/9#issuecomment-47693949

          I tried to comply with the contributor guidelines for the Pull Request. Can you be specific to what I am doing wrong?

          Show
          ASF GitHub Bot added a comment - Github user haydenmarchant commented on the pull request: https://github.com/apache/accumulo/pull/9#issuecomment-47693949 I tried to comply with the contributor guidelines for the Pull Request. Can you be specific to what I am doing wrong?
          Hide
          ASF GitHub Bot added a comment -

          Github user haydenmarchant commented on a diff in the pull request:

          https://github.com/apache/accumulo/pull/9#discussion_r14421467

          — Diff: conf/templates/accumulo-env.sh —
          @@ -51,10 +51,11 @@ test -z "$ACCUMULO_TSERVER_OPTS" && export ACCUMULO_TSERVER_OPTS="$

          {POLICY} ${tS
          test -z "$ACCUMULO_MASTER_OPTS" && export ACCUMULO_MASTER_OPTS="${POLICY}

          $

          {masterHigh_masterLow}

          "
          test -z "$ACCUMULO_MONITOR_OPTS" && export ACCUMULO_MONITOR_OPTS="$

          {POLICY}

          $

          {monitorHigh_monitorLow}

          "
          test -z "$ACCUMULO_GC_OPTS" && export ACCUMULO_GC_OPTS="$

          {gcHigh_gcLow}

          "
          -test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="-XX:+UseConcMarkSweepGC -XX:CMSInitiatingOccupancyFraction=75 -Djava.net.preferIPv4Stack=true"
          +test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="$

          {gcPolicy} -Djava.net.preferIPv4Stack=true ${jaxpDocBuilderFactory} ${randomNumGeneratorProviderOverride}"
          test -z "$ACCUMULO_OTHER_OPTS" && export ACCUMULO_OTHER_OPTS="${otherHigh_otherLow}"
          # what do when the JVM runs out of heap memory
          export ACCUMULO_KILL_CMD='kill -9 %p'
          +export GC_POLICY_ARGS="${gcPolicy}

          "
          — End diff –

          The intention is that this variable will be used by the MiniAccumuloCluster class when the MiniAccumuloClusterImpl class launches the Table Server using Java exec. At the moment, the class has hard-coded the GC params for Sun JVM. My intention is that it will use System.getenv("GC_POLICY_ARGS").

          I did not include this change yet.

          If the approach that I've taken makes sense, let me know and I will complete the change to MiniAccumuloClusterImpl

          Show
          ASF GitHub Bot added a comment - Github user haydenmarchant commented on a diff in the pull request: https://github.com/apache/accumulo/pull/9#discussion_r14421467 — Diff: conf/templates/accumulo-env.sh — @@ -51,10 +51,11 @@ test -z "$ACCUMULO_TSERVER_OPTS" && export ACCUMULO_TSERVER_OPTS="$ {POLICY} ${tS test -z "$ACCUMULO_MASTER_OPTS" && export ACCUMULO_MASTER_OPTS="${POLICY} $ {masterHigh_masterLow} " test -z "$ACCUMULO_MONITOR_OPTS" && export ACCUMULO_MONITOR_OPTS="$ {POLICY} $ {monitorHigh_monitorLow} " test -z "$ACCUMULO_GC_OPTS" && export ACCUMULO_GC_OPTS="$ {gcHigh_gcLow} " -test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="-XX:+UseConcMarkSweepGC -XX:CMSInitiatingOccupancyFraction=75 -Djava.net.preferIPv4Stack=true" +test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="$ {gcPolicy} -Djava.net.preferIPv4Stack=true ${jaxpDocBuilderFactory} ${randomNumGeneratorProviderOverride}" test -z "$ACCUMULO_OTHER_OPTS" && export ACCUMULO_OTHER_OPTS="${otherHigh_otherLow}" # what do when the JVM runs out of heap memory export ACCUMULO_KILL_CMD='kill -9 %p' +export GC_POLICY_ARGS="${gcPolicy} " — End diff – The intention is that this variable will be used by the MiniAccumuloCluster class when the MiniAccumuloClusterImpl class launches the Table Server using Java exec. At the moment, the class has hard-coded the GC params for Sun JVM. My intention is that it will use System.getenv("GC_POLICY_ARGS"). I did not include this change yet. If the approach that I've taken makes sense, let me know and I will complete the change to MiniAccumuloClusterImpl
          Hide
          ASF GitHub Bot added a comment -

          Github user busbey commented on a diff in the pull request:

          https://github.com/apache/accumulo/pull/9#discussion_r14414275

          — Diff: conf/templates/accumulo-env.sh —
          @@ -51,10 +51,11 @@ test -z "$ACCUMULO_TSERVER_OPTS" && export ACCUMULO_TSERVER_OPTS="$

          {POLICY} ${tS
          test -z "$ACCUMULO_MASTER_OPTS" && export ACCUMULO_MASTER_OPTS="${POLICY}

          $

          {masterHigh_masterLow}

          "
          test -z "$ACCUMULO_MONITOR_OPTS" && export ACCUMULO_MONITOR_OPTS="$

          {POLICY}

          $

          {monitorHigh_monitorLow}

          "
          test -z "$ACCUMULO_GC_OPTS" && export ACCUMULO_GC_OPTS="$

          {gcHigh_gcLow}

          "
          -test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="-XX:+UseConcMarkSweepGC -XX:CMSInitiatingOccupancyFraction=75 -Djava.net.preferIPv4Stack=true"
          +test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="$

          {gcPolicy} -Djava.net.preferIPv4Stack=true ${jaxpDocBuilderFactory} ${randomNumGeneratorProviderOverride}"
          test -z "$ACCUMULO_OTHER_OPTS" && export ACCUMULO_OTHER_OPTS="${otherHigh_otherLow}"
          # what do when the JVM runs out of heap memory
          export ACCUMULO_KILL_CMD='kill -9 %p'
          +export GC_POLICY_ARGS="${gcPolicy}

          "
          — End diff –

          where does this exported variable actually get used?

          Show
          ASF GitHub Bot added a comment - Github user busbey commented on a diff in the pull request: https://github.com/apache/accumulo/pull/9#discussion_r14414275 — Diff: conf/templates/accumulo-env.sh — @@ -51,10 +51,11 @@ test -z "$ACCUMULO_TSERVER_OPTS" && export ACCUMULO_TSERVER_OPTS="$ {POLICY} ${tS test -z "$ACCUMULO_MASTER_OPTS" && export ACCUMULO_MASTER_OPTS="${POLICY} $ {masterHigh_masterLow} " test -z "$ACCUMULO_MONITOR_OPTS" && export ACCUMULO_MONITOR_OPTS="$ {POLICY} $ {monitorHigh_monitorLow} " test -z "$ACCUMULO_GC_OPTS" && export ACCUMULO_GC_OPTS="$ {gcHigh_gcLow} " -test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="-XX:+UseConcMarkSweepGC -XX:CMSInitiatingOccupancyFraction=75 -Djava.net.preferIPv4Stack=true" +test -z "$ACCUMULO_GENERAL_OPTS" && export ACCUMULO_GENERAL_OPTS="$ {gcPolicy} -Djava.net.preferIPv4Stack=true ${jaxpDocBuilderFactory} ${randomNumGeneratorProviderOverride}" test -z "$ACCUMULO_OTHER_OPTS" && export ACCUMULO_OTHER_OPTS="${otherHigh_otherLow}" # what do when the JVM runs out of heap memory export ACCUMULO_KILL_CMD='kill -9 %p' +export GC_POLICY_ARGS="${gcPolicy} " — End diff – where does this exported variable actually get used?
          Hide
          ASF GitHub Bot added a comment -

          Github user busbey commented on the pull request:

          https://github.com/apache/accumulo/pull/9#issuecomment-47677181

          Please update the commit message to use the format requested [in the contributor guide][1] (specifically see step 5)

          [1]: http://accumulo.apache.org/git.html#contributors

          Show
          ASF GitHub Bot added a comment - Github user busbey commented on the pull request: https://github.com/apache/accumulo/pull/9#issuecomment-47677181 Please update the commit message to use the format requested [in the contributor guide] [1] (specifically see step 5) [1] : http://accumulo.apache.org/git.html#contributors
          Hide
          ASF GitHub Bot added a comment -

          Github user haydenmarchant commented on the pull request:

          https://github.com/apache/accumulo/pull/9#issuecomment-47626599

          commits have been squashed and pushed to my branch.

          Show
          ASF GitHub Bot added a comment - Github user haydenmarchant commented on the pull request: https://github.com/apache/accumulo/pull/9#issuecomment-47626599 commits have been squashed and pushed to my branch.
          Hide
          ASF GitHub Bot added a comment -

          Github user busbey commented on the pull request:

          https://github.com/apache/accumulo/pull/9#issuecomment-47536342

          Can you make sure you've pushed the updated version to your ACCUMULO-2944 branch? That will update this PR. Right now it looks like the previous 2 commits are still there.

          Show
          ASF GitHub Bot added a comment - Github user busbey commented on the pull request: https://github.com/apache/accumulo/pull/9#issuecomment-47536342 Can you make sure you've pushed the updated version to your ACCUMULO-2944 branch? That will update this PR. Right now it looks like the previous 2 commits are still there.
          Hide
          ASF GitHub Bot added a comment -

          Github user haydenmarchant commented on the pull request:

          https://github.com/apache/accumulo/pull/9#issuecomment-47521313

          Requested changes have been made (squashed commit and bug in the if statement.

          Show
          ASF GitHub Bot added a comment - Github user haydenmarchant commented on the pull request: https://github.com/apache/accumulo/pull/9#issuecomment-47521313 Requested changes have been made (squashed commit and bug in the if statement.
          Hide
          Hayden Marchant added a comment -

          Corey, frequently the default JAVA_HOME in the shell might not be set with the desired JVM since a number of different versions could be installed. I agree that it might be desirable to suggest the JVM installed on JAVA_HOME as a default selection if no other specific ones are selected.

          Should this be recorded as an enhancement in a separate JIRA?

          Show
          Hayden Marchant added a comment - Corey, frequently the default JAVA_HOME in the shell might not be set with the desired JVM since a number of different versions could be installed. I agree that it might be desirable to suggest the JVM installed on JAVA_HOME as a default selection if no other specific ones are selected. Should this be recorded as an enhancement in a separate JIRA?
          Christopher Tubbs made changes -
          Link This issue relates to ACCUMULO-2646 [ ACCUMULO-2646 ]
          Hide
          Corey J. Nolet added a comment -

          In an effort to make this painless for users, could we use the java -version from the $JAVA_HOME to figure out which JVM should be configured?

          Show
          Corey J. Nolet added a comment - In an effort to make this painless for users, could we use the java -version from the $JAVA_HOME to figure out which JVM should be configured?
          Sean Busbey made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Sean Busbey made changes -
          Assignee Hayden Marchant [ haydenmarchant ]
          Hide
          Sean Busbey added a comment -

          in review on github PR 9

          Show
          Sean Busbey added a comment - in review on github PR 9
          Hayden Marchant made changes -
          Field Original Value New Value
          Component/s build [ 12316304 ]
          Hayden Marchant created issue -

            People

            • Assignee:
              Hayden Marchant
              Reporter:
              Hayden Marchant
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:

                Time Tracking

                Estimated:
                Original Estimate - 72h
                72h
                Remaining:
                Remaining Estimate - 72h
                72h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development