Uploaded image for project: 'HttpComponents HttpClient'
  1. HttpComponents HttpClient
  2. HTTPCLIENT-2030

PublicSuffixMatcher::getDomainRoot with expectation fails on invalid domain names.

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 5.0 Beta7
    • None
    • None

    Description

      Assume 
          PublicSuffixMatcher matcher = PublicSuffixMatcherLoader.getDefault();
      Then this 
          matcher.getDomainRoot("www.example.unknown")
      returns
          "unknown"
      which is correct because no expectation was given about the domain name.

      However when I do set a required expectation with something like
          matcher.getDomainRoot("www.example.unknown", DomainType.ICANN)
      then the current implementation still returns
         "unknown"
      instead of the expected 
         null
      indicating that there was no match.

       

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            nielsbasjes Niels Basjes
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 50m
                1h 50m

                Slack

                  Issue deployment