[HTTPCLIENT-2030] PublicSuffixMatcher::getDomainRoot with expectation fails on invalid domain names.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.0 Beta7
• Assignee: Unassigned
• Reporter: Niels Basjes
• Created: 22/Nov/19 11:37
• Updated: 26/Nov/19 13:11
• Resolved: 26/Nov/19 10:55

Description

Assume 
    PublicSuffixMatcher matcher = PublicSuffixMatcherLoader.getDefault();
Then this 
    matcher.getDomainRoot("www.example.unknown")
returns
    "unknown"
which is correct because no expectation was given about the domain name.

However when I do set a required expectation with something like
    matcher.getDomainRoot("www.example.unknown", DomainType.ICANN)
then the current implementation still returns
   "unknown"
instead of the expected 
   null
indicating that there was no match.

 

Issue Links

• links to: GitHub Pull Request #174
• links to: GitHub Pull Request #176