Uploaded image for project: 'HttpComponents HttpClient'
  1. HttpComponents HttpClient
  2. HTTPCLIENT-2030

PublicSuffixMatcher::getDomainRoot with expectation fails on invalid domain names.

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0 Beta7
    • Component/s: None
    • Labels:
      None

      Description

      Assume 
          PublicSuffixMatcher matcher = PublicSuffixMatcherLoader.getDefault();
      Then this 
          matcher.getDomainRoot("www.example.unknown")
      returns
          "unknown"
      which is correct because no expectation was given about the domain name.

      However when I do set a required expectation with something like
          matcher.getDomainRoot("www.example.unknown", DomainType.ICANN)
      then the current implementation still returns
         "unknown"
      instead of the expected 
         null
      indicating that there was no match.

       

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              nielsbasjes Niels Basjes
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 50m
                1h 50m