Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-623

ClientBase in bookkeeper.util requires junit

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: contrib-bookkeeper
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Class org.apache.bookkeeper.util.ClientBase requires junit, and when I tried to just compile bookkeeper, no test, with the patch of ZOOKEEPER-534, compilation failed.

      1. ZOOKEEPER-623_2.patch
        2 kB
        Benjamin Reed
      2. ZOOKEEPER-623_2.patch
        2 kB
        Benjamin Reed
      3. ZOOKEEPER-623.patch
        21 kB
        Flavio Junqueira
      4. ZOOKEEPER-623.patch
        31 kB
        Flavio Junqueira

        Issue Links

          Activity

          Hide
          fpj Flavio Junqueira added a comment -

          This patch moves ClientBase to the test package and eliminates the dependency of LocalBookkeeper class to ClientBase (LocalBookkeeper is a class for running BookKeeper manually in a single computer).

          Show
          fpj Flavio Junqueira added a comment - This patch moves ClientBase to the test package and eliminates the dependency of LocalBookkeeper class to ClientBase (LocalBookkeeper is a class for running BookKeeper manually in a single computer).
          Hide
          fpj Flavio Junqueira added a comment -

          Re-trying hudson.

          Show
          fpj Flavio Junqueira added a comment - Re-trying hudson.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12427900/ZOOKEEPER-623.patch
          against trunk revision 889848.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/86/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/86/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/86/console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12427900/ZOOKEEPER-623.patch against trunk revision 889848. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/86/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/86/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/86/console This message is automatically generated.
          Hide
          mahadev Mahadev konar added a comment -

          flavio,
          Is this ClientBase file the same as in top level src/java/test? If yes, why are we not using that instead of copying it over to bookkeeper directory? We can just add a dependency on ant compile-test to be run from top level before you can run the ant test in bookkeeper and add build/test/classes to the classpath? no?

          Show
          mahadev Mahadev konar added a comment - flavio, Is this ClientBase file the same as in top level src/java/test? If yes, why are we not using that instead of copying it over to bookkeeper directory? We can just add a dependency on ant compile-test to be run from top level before you can run the ant test in bookkeeper and add build/test/classes to the classpath? no?
          Hide
          fpj Flavio Junqueira added a comment -

          It is a good observation, Mahadev. I'm uploading a new patch that uses the zookeeper version of the class. This patch, however, does not compile because we need to modify bookeeper/build.xml as you suggest. I haven't had a chance to look into it so if you know exactly what to modify, please either make the modification yourself or let me know where it is.

          Show
          fpj Flavio Junqueira added a comment - It is a good observation, Mahadev. I'm uploading a new patch that uses the zookeeper version of the class. This patch, however, does not compile because we need to modify bookeeper/build.xml as you suggest. I haven't had a chance to look into it so if you know exactly what to modify, please either make the modification yourself or let me know where it is.
          Hide
          breed Benjamin Reed added a comment -

          Committed revision 891809.

          Show
          breed Benjamin Reed added a comment - Committed revision 891809.
          Hide
          breed Benjamin Reed added a comment -

          makes bookkeeper tests work again.

          Show
          breed Benjamin Reed added a comment - makes bookkeeper tests work again.
          Hide
          mahadev Mahadev konar added a comment -

          +1 great patch ben!!!

          Show
          mahadev Mahadev konar added a comment - +1 great patch ben!!!
          Hide
          breed Benjamin Reed added a comment -

          updated to not try to resolve ClientBase and print a better message.

          Show
          breed Benjamin Reed added a comment - updated to not try to resolve ClientBase and print a better message.
          Hide
          mahadev Mahadev konar added a comment -

          reopening the issue.

          Show
          mahadev Mahadev konar added a comment - reopening the issue.
          Hide
          hudson Hudson added a comment -

          Integrated in ZooKeeper-trunk #632 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/632/)

          Show
          hudson Hudson added a comment - Integrated in ZooKeeper-trunk #632 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/632/ )
          Hide
          hudson Hudson added a comment -

          Integrated in ZooKeeper-trunk #633 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/633/)
          . ClientBase in bookkeeper.util requires junit

          Show
          hudson Hudson added a comment - Integrated in ZooKeeper-trunk #633 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/633/ ) . ClientBase in bookkeeper.util requires junit
          Hide
          fpj Flavio Junqueira added a comment -

          Has been integrated into trunk.

          Show
          fpj Flavio Junqueira added a comment - Has been integrated into trunk.

            People

            • Assignee:
              fpj Flavio Junqueira
              Reporter:
              fpj Flavio Junqueira
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development