Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-534

The test target in contib/bookkeeper does not depend on jar target.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.0, 3.2.1
    • Fix Version/s: 3.3.0
    • Component/s: contrib-bookkeeper
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The test target in contib/bookkeeper does not depend on jar target. So the ant test target gives compilation errors if the main is not compiled which can be prevented if it depends on jar. It can then check if main has been compiled or not and throw out a reasonable error.

        Issue Links

          Activity

          Hide
          phunt Patrick Hunt added a comment -

          updated bk and rest contribs to get "common" (ie log4j and junit) jars using ivy

          fixed bk init to depend on checkmain, now always checks for zk being compiled first and gives sane warning

          Show
          phunt Patrick Hunt added a comment - updated bk and rest contribs to get "common" (ie log4j and junit) jars using ivy fixed bk init to depend on checkmain, now always checks for zk being compiled first and gives sane warning
          Hide
          mahadev Mahadev konar added a comment -

          trying hudson again.

          Show
          mahadev Mahadev konar added a comment - trying hudson again.
          Hide
          mahadev Mahadev konar added a comment -

          +1 the patch looks good. ill commit as soon as hudson ok's it.

          Show
          mahadev Mahadev konar added a comment - +1 the patch looks good. ill commit as soon as hudson ok's it.
          Hide
          mahadev Mahadev konar added a comment -

          +1 the patch looks good. ill commit as soon as hudson ok's it.

          Show
          mahadev Mahadev konar added a comment - +1 the patch looks good. ill commit as soon as hudson ok's it.
          Hide
          hadoopqa Hadoop QA added a comment -

          +1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12426643/ZOOKEEPER-534.patch
          against trunk revision 889848.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 5 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/25/testReport/
          Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/25/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/25/console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12426643/ZOOKEEPER-534.patch against trunk revision 889848. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/25/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/25/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/25/console This message is automatically generated.
          Hide
          fpj Flavio Junqueira added a comment -

          +1 for this patch. However, to have compilation working 100%, we need ZOOKEEPER-623 as well.

          Show
          fpj Flavio Junqueira added a comment - +1 for this patch. However, to have compilation working 100%, we need ZOOKEEPER-623 as well.
          Hide
          mahadev Mahadev konar added a comment -

          I just committed this. thanks pat.

          Show
          mahadev Mahadev konar added a comment - I just committed this. thanks pat.
          Hide
          hudson Hudson added a comment -

          Integrated in ZooKeeper-trunk #632 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/632/)

          Show
          hudson Hudson added a comment - Integrated in ZooKeeper-trunk #632 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/632/ )

            People

            • Assignee:
              phunt Patrick Hunt
              Reporter:
              mahadev Mahadev konar
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development