[ZOOKEEPER-469] make sure CPPUNIT_CFLAGS isn't overwritten

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.2.1, 3.3.0
• Component/s: c client
• Hadoop Flags: Reviewed
• Release Note: Ensure custom CPPUNIT_CFLAGS is not overwritten.
• Assignee: Chris Darroch
• Reporter: Chris Darroch
• Created: 14/Jul/09 18:10
• Updated: 05/Sep/09 22:36
• Resolved: 16/Jul/09 23:30

Description

When compiling with --with-cppunit-prefix, CPPUNIT_CFLAGS is set by the AM_PATH_CPPUNIT macro. In configure.ac, it is then reset in order to set the -DZKSERVER_CMD command line argument. Instead, that argument should be added to CPPUNIT_CFLAGS so that things like a custom -I include location set by AM_PATH_CPPUNIT are not lost. Otherwise, a custom cppunit installation is not properly supported, despite the --with-cppunit-prefix option.