ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-469

make sure CPPUNIT_CFLAGS isn't overwritten

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.2.0
    • Fix Version/s: 3.2.1, 3.3.0
    • Component/s: c client
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Ensure custom CPPUNIT_CFLAGS is not overwritten.

      Description

      When compiling with --with-cppunit-prefix, CPPUNIT_CFLAGS is set by the AM_PATH_CPPUNIT macro. In configure.ac, it is then reset in order to set the -DZKSERVER_CMD command line argument. Instead, that argument should be added to CPPUNIT_CFLAGS so that things like a custom -I include location set by AM_PATH_CPPUNIT are not lost. Otherwise, a custom cppunit installation is not properly supported, despite the --with-cppunit-prefix option.

      1. ZOOKEEPER-469.patch
        0.7 kB
        Chris Darroch

        Activity

        Hide
        Chris Darroch added a comment -

        I've pulled this from ZOOKEEPER-316 because it was getting lost there, I think, and is technically unrelated to the problem first reported there. This should be a much more straightforward fix for a problem that doesn't relate to any licensing issues for cppunit, for example. Sorry for any confusion.

        Show
        Chris Darroch added a comment - I've pulled this from ZOOKEEPER-316 because it was getting lost there, I think, and is technically unrelated to the problem first reported there. This should be a much more straightforward fix for a problem that doesn't relate to any licensing issues for cppunit, for example. Sorry for any confusion.
        Hide
        Mahadev konar added a comment -

        +1 to the patch. I will commit it to both 3.2.1 and trunk.

        Show
        Mahadev konar added a comment - +1 to the patch. I will commit it to both 3.2.1 and trunk.
        Hide
        Mahadev konar added a comment -

        I just committed this to trunk and 3.2.1. thanks chris.

        Show
        Mahadev konar added a comment - I just committed this to trunk and 3.2.1. thanks chris.
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #393 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/393/)

        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #393 (See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/393/ )

          People

          • Assignee:
            Chris Darroch
            Reporter:
            Chris Darroch
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development