[ZOOKEEPER-4362] ZKDatabase.txnCount logged non transactional requests

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.8.0, 3.7.1, 3.6.4
• Component/s: server
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: LiAoNan
• Created: 01/Sep/21 00:19
• Updated: 09/Oct/23 11:20
• Resolved: 13/Nov/21 07:21

Description

ZKDatabase.txnCount logged non transactional requests

    public boolean append(Request si) throws IOException {
        txnCount.incrementAndGet();
        return this.snapLog.append(si);
    }

snaplog.append may return false, but txnCount increased

maybe it would be better

    public boolean append(Request si) throws IOException {
        if (this.snapLog.append(si)) {
            txnCount.incrementAndGet();
            return true;
        }
        return false;
    }

Issue Links

• causes: ZOOKEEPER-4446 branch-3.6 txnLogCountTest use wrong version of Junit Assert import
• links to: GitHub Pull Request #1744