[ZOOKEEPER-4446] branch-3.6 txnLogCountTest use wrong version of Junit Assert import

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.6.4
• Fix Version/s: 3.6.4
• Component/s: server
• Labels: pull-request-available

Language

Java

• Assignee: Unassigned
• Reporter: Phang Khar Yeow
• Created: 19/Jan/22 13:20
• Updated: 09/Oct/23 11:20
• Resolved: 13/Dec/22 17:44

Description

The issue is due to https://github.com/apache/zookeeper/blob/branch-3.6/zookeeper-server/src/test/java/org/apache/zookeeper/server/TxnLogCountTest.java

import static org.junit.jupiter.api.Assertions.assertEquals; 

Cause the compilation error, since Junit 4 still in used.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project zookeeper: Compilation failure: Compilation failure: 

  

  
    
    [ERROR] /home/runner/work/zookeeper/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/TxnLogCountTest.java:[21,36] package org.junit.jupiter.api does not exist

  

  
    
    [ERROR] /home/runner/work/zookeeper/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/TxnLogCountTest.java:[21,1] static import only from classes and interfaces

  

  
    
    [ERROR] /home/runner/work/zookeeper/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/TxnLogCountTest.java:[49,9] cannot find symbol

  

  
    
    [ERROR]   symbol:   method assertEquals(int,int)

  

  
    
    [ERROR]   location: class org.apache.zookeeper.server.TxnLogCountTest

  

  
    
    [ERROR] /home/runner/work/zookeeper/zookeeper/zookeeper-server/src/test/java/org/apache/zookeeper/server/TxnLogCountTest.java:[52,9] cannot find symbol

  

  
    
    [ERROR]   symbol:   method assertEquals(int,int)

  

  
    
    [ERROR]   location: class org.apache.zookeeper.server.TxnLogCountTest

  

  
    
    [ERROR] -> [Help 1] 

 

 

Issue Links

• is caused by: ZOOKEEPER-4362 ZKDatabase.txnCount logged non transactional requests
• is duplicated by: ZOOKEEPER-4445 branch-3.6 txnLogCountTest use wrong version of Junit Assert import
• links to: GitHub Pull Request #1797