Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-3741

Fix ZooKeeper 3.5 C client build on Fedora8

    XMLWordPrintableJSON

    Details

      Description

      Using new RHEL / Centos8 docker images, it was not possible to build the ZooKeeper C client for 3.5.5 and 3.5.6. The compilation error was fixed by Damien Diederen in ZOOKEEPER-3719 for branch 3.5 and 3.5.7. But one of the errors is still present on the master branch.

      We had a warning that we are trying to call like sprintf(buf,"%s:%d",addrstr,port);, and both buf and addrstr are 128 long char arrays. So in theory, we can overflow. The fix is to increase the length of the destination string array (buf).

      Actually this problem only causing compile time warning / failure only on the 3.5.5 and 3.5.6. On 3.5.7 this was fixed and on 3.6+ branches the compiler can not detect the problem due to some code refactoring made by ZOOKEEPER-3068, but the issue is still present on the master branch.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                symat Mate Szalay-Beko
                Reporter:
                symat Mate Szalay-Beko
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0h
                  0h
                  Logged:
                  Time Spent - 40m
                  40m