[ZOOKEEPER-3719] C Client compilation issues in 3.5.7-rc

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.6
• Fix Version/s: 3.5.7
• Component/s: c client
• Labels: pull-request-available
• Assignee: Damien Diederen
• Reporter: Damien Diederen
• Created: 07/Feb/20 15:45
• Updated: 27/Feb/20 13:13
• Resolved: 09/Feb/20 13:55

Description

The C client included in release-3.5.7-rc0 and release-3.5.7-rc1 suffers from a few issues:

1. It configures, but "forgets" to build the C code in the full-build profile;
2. Compilation actually fails with GCC 8.3, as the the Makefile uses -Werror and the compiler detects a couple possible buffer overruns;
3. The WIN32 branch of the code does not compile because of a change in socket representation.

This should probably be set to "blocker," but I don't know if the C client is supposed to block a release. Oh, and the first issue, at least, also existed in 3.5.6—and it seems nobody complained 

A "pull request" is in the works.

Issue Links

• relates to: ZOOKEEPER-3741 Fix ZooKeeper 3.5 C client build on Fedora8
• links to: GitHub Pull Request #1249