[ZOOKEEPER-2182] Several test suites are not running during pre-commit, because their names do not end with "Test".

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.5.1, 3.6.0
• Component/s: tests
• Assignee: Chris Nauroth
• Reporter: Chris Nauroth
• Created: 07/May/15 18:23
• Updated: 12/May/15 05:47
• Resolved: 12/May/15 05:37

Description

In build.xml, the <junit> task definition uses an include pattern of **/*${test.category}Test.java. This is important so that we don't accidentally try to run utility classes like PortAssignment or TestableZooKeeper as if they were JUnit suites. However, several test suites are misnamed so that they don't satisfy this pattern, and therefore pre-commit hasn't been running them.

ClientRetry
ReconfigFailureCases
WatchEventWhenAutoReset

Issue Links

• is related to: ZOOKEEPER-1667 Watch event isn't handled correctly when a client reestablish to a server
• is related to: ZOOKEEPER-2017 New tests for reconfig failure cases