Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-2182

Several test suites are not running during pre-commit, because their names do not end with "Test".

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.5.0
    • Fix Version/s: 3.5.1, 3.6.0
    • Component/s: tests
    • Labels:
      None

      Description

      In build.xml, the <junit> task definition uses an include pattern of **/*${test.category}Test.java. This is important so that we don't accidentally try to run utility classes like PortAssignment or TestableZooKeeper as if they were JUnit suites. However, several test suites are misnamed so that they don't satisfy this pattern, and therefore pre-commit hasn't been running them.

      ClientRetry
      ReconfigFailureCases
      WatchEventWhenAutoReset

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                cnauroth Chris Nauroth
                Reporter:
                cnauroth Chris Nauroth
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: