[ZOOKEEPER-2080] Fix deadlock in dynamic reconfiguration

• Type: Sub-task
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.2
• Fix Version/s: 3.5.3, 3.6.0
• Component/s: server
• Assignee: Michael Han
• Reporter: Ted Yu
• Created: 12/Nov/14 23:54
• Updated: 18/May/17 03:43
• Resolved: 09/Feb/17 05:10

Description

I got the following test failure on MacBook with trunk code:

Testcase: testCurrentObserverIsParticipantInNewConfig took 93.628 sec
  FAILED
waiting for server 2 being up
junit.framework.AssertionFailedError: waiting for server 2 being up
  at org.apache.zookeeper.server.quorum.ReconfigRecoveryTest.testCurrentObserverIsParticipantInNewConfig(ReconfigRecoveryTest.java:529)
  at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:52)

Issue Links

• breaks: ZOOKEEPER-2778 Potential server deadlock between follower sync with leader and follower receiving external connection requests.
• is blocked by: ZOOKEEPER-901 Redesign of QuorumCnxManager
• is related to: ZOOKEEPER-2246 quorum connection manager takes a long time to shut down
• is related to: ZOOKEEPER-1807 Observers spam each other creating connections to the election addr
• is related to: ZOOKEEPER-2164 fast leader election keeps failing
• relates to: ZOOKEEPER-2778 Potential server deadlock between follower sync with leader and follower receiving external connection requests.
• requires: ZOOKEEPER-1806 testCurrentServersAreObserversInNextConfig failing frequently on trunk with non-jdk6
• links to: GitHub Pull Request #92
• links to: GitHub Pull Request #247