ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1807

Observers spam each other creating connections to the election addr

    Details

    • Type: Bug Bug
    • Status: Reopened
    • Priority: Blocker Blocker
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: 3.5.0, 3.5.1, 3.6.0
    • Component/s: None
    • Labels:
      None

      Description

      Hey Alexander Shraer,

      I noticed today that my Observers are spamming each other trying to open connections to the election port. I've got tons of these:

      2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a connection already for server 9
      2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a connection already for server 10
      2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a connection already for server 6
      2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a connection already for server 12
      2013-11-01 22:19:45,819 - DEBUG [WorkerSender[myid=13]] - There is a connection already for server 14
      

      and so and so on ad nauseam.

      Now, looking around I found this inside FastLeaderElection.java from when you committed ZOOKEEPER-107:

           private void sendNotifications() {
      -        for (QuorumServer server : self.getVotingView().values()) {
      -            long sid = server.id;
      -
      +        for (long sid : self.getAllKnownServerIds()) {
      +            QuorumVerifier qv = self.getQuorumVerifier();
      

      Is that really desired? I suspect that is what's causing Observers to try to connect to each other (as opposed as just connecting to participants). I'll give it a try now and let you know. (Also, we use observer ids that are > 0, and I saw some parts of the code that might not deal with that assumption - so it could be that too..).

      1. ZOOKEEPER-1807.patch
        12 kB
        Raul Gutierrez Segales
      2. notifications-loop.png
        44 kB
        Raul Gutierrez Segales
      3. ZOOKEEPER-1807-alex.patch
        2 kB
        Alexander Shraer
      4. ZOOKEEPER-1807-ver2.patch
        10 kB
        Alexander Shraer
      5. ZOOKEEPER-1807-ver3.patch
        9 kB
        Alexander Shraer
      6. ZOOKEEPER-1807-ver4.patch
        10 kB
        Alexander Shraer
      7. ZOOKEEPER-1807-ver5.patch
        10 kB
        Alexander Shraer
      8. ZOOKEEPER-1807-ver6.patch
        24 kB
        Alexander Shraer
      9. ZOOKEEPER-1807-ver7.patch
        38 kB
        Alexander Shraer

        Issue Links

          Activity

          Flavio Junqueira made changes -
          Fix Version/s 3.5.1 [ 12326786 ]
          Fix Version/s 3.6.0 [ 12326518 ]
          Flavio Junqueira made changes -
          Resolution Fixed [ 1 ]
          Status Resolved [ 5 ] Reopened [ 4 ]
          Flavio Junqueira made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Alexander Shraer made changes -
          Attachment ZOOKEEPER-1807-ver7.patch [ 12656544 ]
          Alexander Shraer made changes -
          Attachment ZOOKEEPER-1807-ver6.patch [ 12656256 ]
          Alexander Shraer made changes -
          Attachment ZOOKEEPER-1807-ver6.patch [ 12656253 ]
          Alexander Shraer made changes -
          Attachment ZOOKEEPER-1807-ver6.patch [ 12656253 ]
          Alexander Shraer made changes -
          Attachment ZOOKEEPER-1807-ver5.patch [ 12640553 ]
          Alexander Shraer made changes -
          Attachment ZOOKEEPER-1807-ver5.patch [ 12612698 ]
          Alexander Shraer made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Alexander Shraer made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Michi Mutsuzaki made changes -
          Priority Major [ 3 ] Blocker [ 1 ]
          Alexander Shraer made changes -
          Attachment ZOOKEEPER-1807-ver5.patch [ 12612698 ]
          Alexander Shraer made changes -
          Attachment ZOOKEEPER-1807-ver4.patch [ 12612664 ]
          Alexander Shraer made changes -
          Attachment ZOOKEEPER-1807-ver3.patch [ 12612635 ]
          Alexander Shraer made changes -
          Link This issue depends upon ZOOKEEPER-1783 [ ZOOKEEPER-1783 ]
          Alexander Shraer made changes -
          Attachment ZOOKEEPER-1807-ver2.patch [ 12612295 ]
          Alexander Shraer made changes -
          Assignee Germán Blanco [ abranzyck ] Alexander Shraer [ shralex ]
          Alexander Shraer made changes -
          Attachment ZOOKEEPER-1807-alex.patch [ 12612023 ]
          Raul Gutierrez Segales made changes -
          Attachment notifications-loop.png [ 12611999 ]
          Germán Blanco made changes -
          Assignee Raul Gutierrez Segales [ rgs ] Germán Blanco [ abranzyck ]
          Raul Gutierrez Segales made changes -
          Attachment ZOOKEEPER-1807.patch [ 12611988 ]
          Raul Gutierrez Segales made changes -
          Attachment ZOOKEEPER-1807.patch [ 12611781 ]
          Raul Gutierrez Segales made changes -
          Issue Type New Feature [ 2 ] Bug [ 1 ]
          sue38 made changes -
          Issue Type Bug [ 1 ] New Feature [ 2 ]
          Raul Gutierrez Segales made changes -
          Attachment ZOOKEEPER-1807.patch [ 12611781 ]
          Raul Gutierrez Segales made changes -
          Attachment ZOOKEEPER-1807.patch [ 12611737 ]
          Raul Gutierrez Segales made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Raul Gutierrez Segales made changes -
          Attachment ZOOKEEPER-1807.patch [ 12611737 ]
          Flavio Junqueira made changes -
          Field Original Value New Value
          Fix Version/s 3.5.0 [ 12316644 ]
          Raul Gutierrez Segales created issue -

            People

            • Assignee:
              Alexander Shraer
              Reporter:
              Raul Gutierrez Segales
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:

                Development