[ZOOKEEPER-1784] Logic to process INFORMANDACTIVATE packets in syncWithLeader seems bogus

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.5.0
• Fix Version/s: 3.5.1
• Release Note: Committed to trunk. Thanks Raul, and sorry that it took so long to commit.
• Assignee: Raúl Gutiérrez Segalés
• Reporter: Raúl Gutiérrez Segalés
• Created: 08/Oct/13 19:18
• Updated: 07/Apr/15 21:15
• Resolved: 25/Jan/15 00:23

Description

If you look at Learner#syncWithLeader:

            while (self.isRunning()) {
                readPacket(qp);
                switch(qp.getType()) {
.......

                case Leader.INFORM:
                case Leader.INFORMANDACTIVATE:
                    PacketInFlight packet = new PacketInFlight();
                    packet.hdr = new TxnHeader();

                    if (qp.getType() == Leader.COMMITANDACTIVATE) {

I guess "qp.getType() == Leader.COMMITANDACTIVATE" is a typo that should read "qp.getType() == Leader.INFORMANDACTIVATE".

Assigning to Alexander for now since this is part of ZOOKEEPER-107.