Uploaded image for project: 'ZooKeeper'
  1. ZooKeeper
  2. ZOOKEEPER-1784

Logic to process INFORMANDACTIVATE packets in syncWithLeader seems bogus

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.5.0
    • Fix Version/s: 3.5.1
    • Component/s: None
    • Labels:
      None
    • Release Note:
      Committed to trunk. Thanks Raul, and sorry that it took so long to commit.

      Description

      If you look at Learner#syncWithLeader:

                  while (self.isRunning()) {
                      readPacket(qp);
                      switch(qp.getType()) {
      .......
      
                      case Leader.INFORM:
                      case Leader.INFORMANDACTIVATE:
                          PacketInFlight packet = new PacketInFlight();
                          packet.hdr = new TxnHeader();
      
                          if (qp.getType() == Leader.COMMITANDACTIVATE) {
      

      I guess "qp.getType() == Leader.COMMITANDACTIVATE" is a typo that should read "qp.getType() == Leader.INFORMANDACTIVATE".

      Assigning to Alexander for now since this is part of ZOOKEEPER-107.

        Attachments

        1. ZOOKEEPER-1784.patch
          0.8 kB
          Raul Gutierrez Segales
        2. ZOOKEEPER-1784.patch
          0.8 kB
          Alexander Shraer

          Activity

            People

            • Assignee:
              rgs Raul Gutierrez Segales
              Reporter:
              rgs Raul Gutierrez Segales
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: