Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 3.5.0
    • Fix Version/s: 3.5.4, 3.6.0
    • Component/s: None
    • Labels:
      None

      Description

      ZOOKEEPER-1355. Add zk.updateServerList(newServerList) (Alex Shraer, Marshall McMullen via fpj)

      git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1410731 13f79535-47bb-0310-9956-ffa450edef68

      +int addrvec_contains(const addrvec_t *avec, const struct sockaddr_storage *addr)
      +{
      + if (!avec || !addr)
      +

      { + return 0; + }

      +
      + int i = 0;
      + for (i = 0; i < avec->count; i++)
      +

      { + if(memcmp(&avec->data[i], addr, INET_ADDRSTRLEN) == 0) + return 1; + }

      +
      + return 0;
      +}

      Pretty sure that should be sizeof(sockaddr_storage). INET_ADDRSTRLEN is the size of the character buffer which needs to be allocated for the return value of inet_ntop, which seems to be totally wrong.

        Attachments

        1. ZOOKEEPER-1677.patch
          1 kB
          Marshall McMullen
        2. ZOOKEEPER-1677.patch
          1 kB
          Marshall McMullen
        3. ZOOKEEPER-1677.patch
          1 kB
          Marshall McMullen
        4. ZOOKEEPER-1677.patch
          1 kB
          Camille Fournier
        5. ZOOKEEPER-1677.patch
          4 kB
          Michi Mutsuzaki
        6. ZOOKEEPER-1677.patch
          4 kB
          Michi Mutsuzaki
        7. ZOOKEEPER-1677.patch
          5 kB
          Michi Mutsuzaki
        8. ZOOKEEPER-1677.patch
          5 kB
          Michi Mutsuzaki
        9. ZOOKEEPER-1677.patch
          6 kB
          Michi Mutsuzaki

          Activity

            People

            • Assignee:
              marshall Marshall McMullen
              Reporter:
              arren Shevek
            • Votes:
              1 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated: