[ZOOKEEPER-1677] Misuse of INET_ADDRSTRLEN

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 3.5.0
• Fix Version/s: 3.7.0, 3.6.1, 3.5.8
• Assignee: Unassigned
• Reporter: Shevek
• Created: 28/Mar/13 21:00
• Updated: 11/May/20 15:41
• Resolved: 14/Apr/20 10:02

Description

ZOOKEEPER-1355. Add zk.updateServerList(newServerList) (Alex Shraer, Marshall McMullen via fpj)

git-svn-id: https://svn.apache.org/repos/asf/zookeeper/trunk@1410731 13f79535-47bb-0310-9956-ffa450edef68

+int addrvec_contains(const addrvec_t *avec, const struct sockaddr_storage *addr)
+{
+ if (!avec || !addr)
+

{ + return 0; + }

+
+ int i = 0;
+ for (i = 0; i < avec->count; i++)
+

{ + if(memcmp(&avec->data[i], addr, INET_ADDRSTRLEN) == 0) + return 1; + }

+
+ return 0;
+}

Pretty sure that should be sizeof(sockaddr_storage). INET_ADDRSTRLEN is the size of the character buffer which needs to be allocated for the return value of inet_ntop, which seems to be totally wrong.

Issue Links

• is fixed by: ZOOKEEPER-3726 invalid ipv6 address comparison in C client
• is related to: ZOOKEEPER-3726 invalid ipv6 address comparison in C client