ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1503

remove redundant JAAS configuration code in SaslAuthTest and SaslAuthFailTest

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.4.4, 3.5.0
    • Component/s: None
    • Labels:
      None
    • Environment:

      In SaslAuthTest and SaslAuthFail test, we set the JAAS configuration twice with the same text string. This is confusing and redundant, since we need only set it once.

    • Hadoop Flags:
      Reviewed

      Issue Links

        Activity

        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12535236/ZOOKEEPER-1503.patch
        against trunk revision 1357711.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 6 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        +1 core tests. The patch passed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1123//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1123//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1123//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12535236/ZOOKEEPER-1503.patch against trunk revision 1357711. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 6 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1123//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1123//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1123//console This message is automatically generated.
        Hide
        Patrick Hunt added a comment -

        Great. Always appreciate test submissions. Thanks Eugene!

        Show
        Patrick Hunt added a comment - Great. Always appreciate test submissions. Thanks Eugene!
        Hide
        Patrick Hunt added a comment -

        Btw. I noticed that these tests are using a static block rather than using junit's before/after or beforeclass/afterclass. Eugene would you mind fixing this via a new jira? (unless there's a reason why you didn't use junit for this...)

        Show
        Patrick Hunt added a comment - Btw. I noticed that these tests are using a static block rather than using junit's before/after or beforeclass/afterclass. Eugene would you mind fixing this via a new jira? (unless there's a reason why you didn't use junit for this...)
        Hide
        Eugene Koontz added a comment -

        Sure thing, thanks for noticing that, Patrick.

        https://issues.apache.org/jira/browse/ZOOKEEPER-1524

        Show
        Eugene Koontz added a comment - Sure thing, thanks for noticing that, Patrick. https://issues.apache.org/jira/browse/ZOOKEEPER-1524
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1632 (See https://builds.apache.org/job/ZooKeeper-trunk/1632/)
        ZOOKEEPER-1503. remove redundant JAAS configuration code in SaslAuthTest and SaslAuthFailTest ((Eugene Koontz via phunt) (Revision 1368203)

        Result = SUCCESS
        phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368203
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/SaslAuthFailTest.java
        • /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/SaslAuthTest.java
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1632 (See https://builds.apache.org/job/ZooKeeper-trunk/1632/ ) ZOOKEEPER-1503 . remove redundant JAAS configuration code in SaslAuthTest and SaslAuthFailTest ((Eugene Koontz via phunt) (Revision 1368203) Result = SUCCESS phunt : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1368203 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/SaslAuthFailTest.java /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/SaslAuthTest.java

          People

          • Assignee:
            Eugene Koontz
            Reporter:
            Eugene Koontz
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development