[ZOOKEEPER-1524] use more standard junit annotation "@Before" in SaslXTests rather than static blocks

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: tests
• Assignee: Eugene Joseph Koontz
• Reporter: Eugene Joseph Koontz
• Created: 01/Aug/12 19:39
• Updated: 01/Aug/12 19:56

Description

The following tests:

AuthTest.java
SaslAuthFailTest.java
SaslAuthDesignatedClientTest.java
SaslAuthFailDesignatedClientTest.java
SaslAuthMissingClientConfigTest.java
SaslAuthTest.java

use "static

{..}

" blocks to initialize system properties and files prior to the test runs. As Patrick points out in ZOOKEEPER-1503, we should instead use JUnit's @Before annotation:

http://junit.sourceforge.net/javadoc/org/junit/Before.html

rather than static blocks, to make our tests more consistent and easier to understand.

Issue Links

• relates to: ZOOKEEPER-1503 remove redundant JAAS configuration code in SaslAuthTest and SaslAuthFailTest