[ZOOKEEPER-1439] c sdk: core in log_env for lack of checking the output argument *pwp* of getpwuid_r

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.3, 3.3.5
• Fix Version/s: 3.5.0
• Component/s: c client
• Labels: zookeeper

Environment

linux

• Hadoop Flags: Reviewed
• Tags: sdk
• Assignee: Yubing Yin
• Reporter: Yubing Yin
• Created: 01/Apr/12 08:15
• Updated: 27/Apr/12 11:00
• Resolved: 26/Apr/12 10:59

Description

Man of getpwuid_r "return a pointer to a passwd structure, or NULL if the matching entry is not found or an error occurs",
"The getpwnam_r() and getpwuid_r() functions return zero on success.", it means entry may not be found when getpwuid_r success.

In log_env of zookeeper.c in c sdk:
if (!getpwuid_r(uid, &pw, buf, sizeof(buf), &pwp)) {
LOG_INFO(("Client environment:user.home=%s", pw.pw_dir));
}
pwp is not checked to ensure entry is found, pw.pw_dir is not initialized in this case, core happens in LOG_INFO.