ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1439

c sdk: core in log_env for lack of checking the output argument *pwp* of getpwuid_r

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 3.4.3, 3.3.5
    • Fix Version/s: 3.5.0
    • Component/s: c client
    • Labels:
    • Environment:

      linux

    • Hadoop Flags:
      Reviewed
    • Tags:
      sdk

      Description

      Man of getpwuid_r "return a pointer to a passwd structure, or NULL if the matching entry is not found or an error occurs",
      "The getpwnam_r() and getpwuid_r() functions return zero on success.", it means entry may not be found when getpwuid_r success.

      In log_env of zookeeper.c in c sdk:
      if (!getpwuid_r(uid, &pw, buf, sizeof(buf), &pwp)) {
      LOG_INFO(("Client environment:user.home=%s", pw.pw_dir));
      }
      pwp is not checked to ensure entry is found, pw.pw_dir is not initialized in this case, core happens in LOG_INFO.

        Activity

        Hide
        Yubing Yin added a comment -

        check pwp to ensure passwd entry is found, after getpwuid_r, fix core in log_env.

        Show
        Yubing Yin added a comment - check pwp to ensure passwd entry is found, after getpwuid_r, fix core in log_env.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12520815/ZOOKEEPER-1439.patch
        against trunk revision 1307644.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        +1 contrib tests. The patch passed contrib unit tests.

        Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1026//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1026//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1026//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12520815/ZOOKEEPER-1439.patch against trunk revision 1307644. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1026//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1026//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1026//console This message is automatically generated.
        Hide
        Michi Mutsuzaki added a comment -

        Checked in to trunk. Thank you for the patch, Yubing!

        --Michi

        Show
        Michi Mutsuzaki added a comment - Checked in to trunk. Thank you for the patch, Yubing! --Michi
        Hide
        Hudson added a comment -

        Integrated in ZooKeeper-trunk #1539 (See https://builds.apache.org/job/ZooKeeper-trunk/1539/)
        ZOOKEEPER-1439. c sdk: core in log_env for lack of checking the output argument pwp of getpwuid_r (Yubing Yin via michim) (Revision 1330769)

        Result = SUCCESS
        michim : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330769
        Files :

        • /zookeeper/trunk/CHANGES.txt
        • /zookeeper/trunk/src/c/src/zookeeper.c
        Show
        Hudson added a comment - Integrated in ZooKeeper-trunk #1539 (See https://builds.apache.org/job/ZooKeeper-trunk/1539/ ) ZOOKEEPER-1439 . c sdk: core in log_env for lack of checking the output argument pwp of getpwuid_r (Yubing Yin via michim) (Revision 1330769) Result = SUCCESS michim : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1330769 Files : /zookeeper/trunk/CHANGES.txt /zookeeper/trunk/src/c/src/zookeeper.c

          People

          • Assignee:
            Yubing Yin
            Reporter:
            Yubing Yin
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development