ZooKeeper
  1. ZooKeeper
  2. ZOOKEEPER-1033

c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.3
    • Fix Version/s: 3.4.0
    • Component/s: c client
    • Labels:
      None
    • Release Note:
      Install c-client header files into include/zookeeper/ rather than include/c-client-src/

      Description

      header files are installed into foo/include/c-client-src/, which doesn't indicate a relationship with zookeeper and doesn't correspond to foo/lib/libzookeeper*

      header files should be installed into foo/include/zookeeper/ as this is the common practice.

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in ZooKeeper-trunk #1172 (See https://builds.apache.org/hudson/job/ZooKeeper-trunk/1172/)
          ZOOKEEPER-1033. c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src (Nicholas Harteau via mahadev)

          Show
          Hudson added a comment - Integrated in ZooKeeper-trunk #1172 (See https://builds.apache.org/hudson/job/ZooKeeper-trunk/1172/ ) ZOOKEEPER-1033 . c client should install includes into INCDIR/zookeeper, not INCDIR/c-client-src (Nicholas Harteau via mahadev)
          Hide
          Mahadev konar added a comment -

          I just committed this to trunk (without the Changelog changes). Thanks Nicholas!

          Show
          Mahadev konar added a comment - I just committed this to trunk (without the Changelog changes). Thanks Nicholas!
          Hide
          Mahadev konar added a comment -

          Thanks Nicholas,
          The Changelog entries are not needed since we add the changelog as and when the committers commit. Also the Changelog in src/c is stale. We havent been maintaining it. Ill commit without the changelog changes.

          Show
          Mahadev konar added a comment - Thanks Nicholas, The Changelog entries are not needed since we add the changelog as and when the committers commit. Also the Changelog in src/c is stale. We havent been maintaining it. Ill commit without the changelog changes.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12474973/ZOOKEEPER-1033-notidy.patch
          against trunk revision 1082362.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/213//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/213//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/213//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12474973/ZOOKEEPER-1033-notidy.patch against trunk revision 1082362. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/213//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/213//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/213//console This message is automatically generated.
          Hide
          Ivan Kelly added a comment -

          +1

          Good work!

          Show
          Ivan Kelly added a comment - +1 Good work!
          Hide
          Ivan Kelly added a comment -

          yes, your patch should only contain your changes.

          Show
          Ivan Kelly added a comment - yes, your patch should only contain your changes.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12474967/ZOOKEEPER-1033-notabs.patch
          against trunk revision 1082362.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          -1 release audit. The applied patch generated 25 release audit warnings (more than the trunk's current 24 warnings).

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/211//testReport/
          Release audit warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/211//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/211//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/211//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12474967/ZOOKEEPER-1033-notabs.patch against trunk revision 1082362. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. -1 release audit. The applied patch generated 25 release audit warnings (more than the trunk's current 24 warnings). +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/211//testReport/ Release audit warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/211//artifact/trunk/patchprocess/patchReleaseAuditProblems.txt Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/211//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/211//console This message is automatically generated.
          Hide
          Nicholas Harteau added a comment -

          i.e. just remove the changelog cleanup?

          Show
          Nicholas Harteau added a comment - i.e. just remove the changelog cleanup?
          Hide
          Nicholas Harteau added a comment -

          re-patch 1033 w/4-space tabs in changelog.

          Show
          Nicholas Harteau added a comment - re-patch 1033 w/4-space tabs in changelog.
          Hide
          Ivan Kelly added a comment -

          Could you resubmit with everything from the line "@@ -2,3 +8,3 @@" removed (inclusive). Ill +1 once you do.

          Show
          Ivan Kelly added a comment - Could you resubmit with everything from the line "@@ -2,3 +8,3 @@" removed (inclusive). Ill +1 once you do.
          Hide
          Nicholas Harteau added a comment -

          whoops, changelog cleanup w/4-space indentation

          Show
          Nicholas Harteau added a comment - whoops, changelog cleanup w/4-space indentation
          Hide
          Ivan Kelly added a comment -

          Actual changes are good. However, you've reformatted the ChangeLog with tabs. Could you undo this formatting and use spaces for your own changelog entry instead.

          Show
          Ivan Kelly added a comment - Actual changes are good. However, you've reformatted the ChangeLog with tabs. Could you undo this formatting and use spaces for your own changelog entry instead.
          Hide
          Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12474746/ZOOKEEPER-1033-trunk.patch
          against trunk revision 1082362.

          +1 @author. The patch does not contain any @author tags.

          -1 tests included. The patch doesn't appear to include any new or modified tests.
          Please justify why no new tests are needed for this patch.
          Also please list what manual steps were performed to verify this patch.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed core unit tests.

          +1 contrib tests. The patch passed contrib unit tests.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/205//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/205//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/205//console

          This message is automatically generated.

          Show
          Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12474746/ZOOKEEPER-1033-trunk.patch against trunk revision 1082362. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/205//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/205//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-ZOOKEEPER-Build/205//console This message is automatically generated.
          Hide
          Nicholas Harteau added a comment -

          1. change AC_INIT macro's project name to 'zookeeper' from 'c-client-src'
          2. clean up src/c/ChangeLog

          Show
          Nicholas Harteau added a comment - 1. change AC_INIT macro's project name to 'zookeeper' from 'c-client-src' 2. clean up src/c/ChangeLog
          Hide
          Nicholas Harteau added a comment -

          patch against trunk

          Show
          Nicholas Harteau added a comment - patch against trunk
          Hide
          Nicholas Harteau added a comment -

          1. changes the AC_INIT macro's distribution name to 'zookeeper'
          2. clean up formatting in the c client's changelog.

          Show
          Nicholas Harteau added a comment - 1. changes the AC_INIT macro's distribution name to 'zookeeper' 2. clean up formatting in the c client's changelog.

            People

            • Assignee:
              Nicholas Harteau
              Reporter:
              Nicholas Harteau
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development