[YUNIKORN-638] Make placeholder image configurable

• Type: Sub-task
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 1.0.0
• Component/s: shim - kubernetes
• Labels: pull-request-available
• Target Version: 1.0.0
• Assignee: Peter Bacsko
• Reporter: Chaoran Yu
• Created: 10/Apr/21 15:27
• Updated: 03/Oct/22 22:29
• Resolved: 17/Mar/22 05:54

Description

The placeholder image is currently hard-coded as a constant at https://github.com/apache/incubator-yunikorn-k8shim/blob/v0.10.0/pkg/common/constants/constants.go#L55. In many sectors and enterprises, it's common to have restricted internet access. When replacing the placeholder image with something else, the entire k8shim image also needs to be rebuilt. It's more inconvenient when different deployment environments (dev/test, staging and prod) can't access images in another environment.
It would be better if the placeholder image can be configured in the Helm chart: https://github.com/apache/incubator-yunikorn-release/blob/master/helm-charts/yunikorn/values.yaml. That would make CI/CD easier too

Issue Links

• causes: YUNIKORN-1152 Make sure that --placeHolderImage switch is always properly set
• causes: YUNIKORN-1344 Unable to create placeholders if container registry requires secrets
• links to: GitHub Pull Request #83
• links to: GitHub Pull Request #381