[YUNIKORN-590] GetPlaceholderTimeoutParam: undefined param is not an error

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.10
• Fix Version/s: 0.11
• Component/s: shim - kubernetes
• Labels: newbie pull-request-available
• Target Version: 0.11
• Assignee: Chen Yu Teng
• Reporter: Wilfred Spiegelenburg
• Created: 22/Mar/21 02:44
• Updated: 21/Jan/22 21:48
• Resolved: 22/May/21 05:25

Description

The GetPlaceholderTimeoutParam()  return an error when the schedulingPolicyParameters is not defined. There is no requirement to provide the scheduling policy parameter which means that the absence should not return an error. It should just return nil, nil like the other functions in utils.

After this fix the change for YUNIKORN-565 needs to be updated and converted into a real error log as it found the parameter but could not convert it. Just like we do for GetTaskGroupsFromAnnotation() in the same method in the general code.

Issue Links

• is related to: YUNIKORN-565 Remove the WARN log when placeholderTimeout is not defined in taskGroups
• links to: GitHub Pull Request #266