[YUNIKORN-2547] Queue: clean up logic when adding application

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: core - scheduler
• Labels: pull-request-available
• Target Version: 1.6.0
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 08/Apr/24 10:29
• Updated: 10/Sep/24 20:58
• Resolved: 22/Apr/24 13:41

Description

We found two issues when adding an application to a queue:

1. Inside Queue.AddApplication(), we parse and process "quota" and "guaranteed" from the application tags, then we set them on the queue if they have a valid value. We shouldn't be doing this inside AddApplication(), but rather when we're constructing the application object. That way, they're already available when the app is being added.
2. We an add application to the Queue, but this can be reverted immediately if the placeholder doesn't fit or the "sortType" is not FIFO.

Issue Links

• causes: YUNIKORN-2633 Unnecessary warning from Partition when adding an application
• causes: YUNIKORN-2592 Remove spurious log from partition on app addition
• links to: GitHub Pull Request #838