[YETUS-724] github diff vs. patch

• Type: New Feature
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.10.0
• Component/s: Precommit

Release Note

<!-- markdown -->
precommit will now attempt to try both forms of git patches (binary format-patch and ASCII git diff) when working with Github PRs or Gitlab MRs. It will prefer the format-patch style due to accuracy, but will fallback to diff style if the former does not apply successfully.

• Flags: Important
• Assignee: Allen Wittenauer
• Reporter: Allen Wittenauer
• Created: 26/Nov/18 23:10
• Updated: 14/May/19 15:43
• Resolved: 12/Apr/19 17:45

Description

Experience has shown that patch is more accurate diff. However, we could still try diff. Doing so would enable a lot more scenarios where unsquashed commits would work. Warn that reported line numbers and binary files may not be accurate as a result rather than just flat out failing... with the premise that some output is better than none.

Issue Links

• breaks: YETUS-882 command line patch files do not work in docker mode
• contains: YETUS-151 reject multi-commit patches
• links to: GitHub Pull Request #29