Uploaded image for project: 'Yetus'
  1. Yetus
  2. YETUS-151

reject multi-commit patches

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Won't Fix
    • None
    • None
    • Precommit
    • None

    Description

      Given that line comments are likely to be wrong, patch application will likely fail, etc, we should by default reject patches that are more than one commit with a flag to specifically enable them. Part of the messaging on failure should be to suggest rebasing.

      Attachments

        Issue Links

        contains

        Improvement - An improvement or enhancement to an existing feature or task. YETUS-79 mention rebase duing patch failures

        • Trivial - Cosmetic problem like misspelt words or misaligned text.
        • Resolved
        duplicates

        Test - A new unit, integration or system test. HADOOP-10532 Jenkins test-patch timed out on a large patch touching files in multiple modules.

        • Major - Major loss of function.
        • Resolved
        Is contained by

        New Feature - A new feature of the product, which has yet to be developed. YETUS-724 github diff vs. patch

        • Major - Major loss of function.
        • Resolved

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            aw Allen Wittenauer
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment