Uploaded image for project: 'Yetus'
  1. Yetus
  2. YETUS-465

findbugs should not -1 if base branch has warnings when the patch fixes them

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Precommit
    • Labels:
      None

      Description

      In HADOOP-13669, the base branch (trunk) has 2 findbugs warnings, and a patch fixes them. But pre-commit returns:

      -1	findbugs	0m 26s	hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.
      

      IMO this would be better if it says +1 and (had 2 warnings, fixed).

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                xiaochen Xiao Chen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: