Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-13669

KMS Server should log exceptions before throwing

    Details

    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      In some recent investigation, it turns out when KMS throws an exception (into tomcat), it's not logged anywhere and we can only see the exception message from client-side, but not the stacktrace. Logging the stacktrance would help debugging.

      1. HADOOP-13369.2.patch
        34 kB
        Suraj Acharya
      2. HADOOP-13369.patch
        34 kB
        Suraj Acharya
      3. HADOOP-13369.patch.1
        34 kB
        Suraj Acharya
      4. HADOOP-13669.addendem2.patch
        0.5 kB
        Xiao Chen
      5. HADOOP-13669.addendum.patch
        0.7 kB
        Xiao Chen
      6. trigger.02.patch
        1 kB
        Xiao Chen
      7. trigger.patch
        1 kB
        Xiao Chen

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10673 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10673/)
          HADOOP-13669. Addendum patch 2 for KMS Server should log exceptions (xiao: rev 09ef97dccbd4c11aaeedf7503d414f999435ad91)

          • (edit) hadoop-common-project/hadoop-kms/dev-support/findbugsExcludeFile.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10673 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10673/ ) HADOOP-13669 . Addendum patch 2 for KMS Server should log exceptions (xiao: rev 09ef97dccbd4c11aaeedf7503d414f999435ad91) (edit) hadoop-common-project/hadoop-kms/dev-support/findbugsExcludeFile.xml
          Hide
          xiaochen Xiao Chen added a comment -

          Committed addendum2 to trunk, branch-2 and branch-2.8. Thanks again Brahma Reddy Battula for reporting and reviewing! Also thanks Allen for the feedback.

          Show
          xiaochen Xiao Chen added a comment - Committed addendum2 to trunk, branch-2 and branch-2.8. Thanks again Brahma Reddy Battula for reporting and reviewing! Also thanks Allen for the feedback.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Verified addendum2 locally,LGTM,+1..thanks for updating the patch..

          Just for reference, For addendum1 <Bug pattern="REC"/> should like <Bug code="REC"/> and along with pattern should be there.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Verified addendum2 locally,LGTM,+1..thanks for updating the patch.. Just for reference, For addendum1 <Bug pattern="REC"/> should like <Bug code="REC"/> and along with pattern should be there.
          Hide
          xiaochen Xiao Chen added a comment -

          Hi Allen Wittenauer Brahma Reddy Battula Wei-Chiu Chuang,
          Could you take a look at addendum2 and see if it makes sense? I'd like to have trunk fixed soon.

          Thanks.

          Show
          xiaochen Xiao Chen added a comment - Hi Allen Wittenauer Brahma Reddy Battula Wei-Chiu Chuang , Could you take a look at addendum2 and see if it makes sense? I'd like to have trunk fixed soon. Thanks.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks for the quick response Allen Wittenauer! (And sorry for not being clear above)

          I believe what you described is addendum 2: trunk has 2 existing, patch fixed the 2. So as soon as addendum 2 is reviewed, we can commit... right?

          My last comment was for a postmodern on the previously-committed addendum 1. It says trunk has 2 existing, patch passed (but without the explicit (0-2=0) message), so I misunderstood it and thought it fixed the issue.... my bad.

          Show
          xiaochen Xiao Chen added a comment - Thanks for the quick response Allen Wittenauer ! (And sorry for not being clear above) I believe what you described is addendum 2: trunk has 2 existing, patch fixed the 2. So as soon as addendum 2 is reviewed, we can commit... right? My last comment was for a postmodern on the previously-committed addendum 1. It says trunk has 2 existing, patch passed (but without the explicit (0-2=0) message), so I misunderstood it and thought it fixed the issue.... my bad.
          Hide
          aw Allen Wittenauer added a comment -

          I think you're still missing it:

          Pre-process runs and part of it's output is this:

          -1 findbugs 0m 26s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.

          i.e., trunk has 2 existing findbugs issues

          Yetus then starts on it's second pass with the patch in place (the mvninstall lines are good indicators where it is). It then provides this output:

          +1 findbugs 0m 34s hadoop-common-project/hadoop-kms generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)

          .... which indicates the patch fixed the 2 findbugs issues.

          Show
          aw Allen Wittenauer added a comment - I think you're still missing it: Pre-process runs and part of it's output is this: -1 findbugs 0m 26s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings. i.e., trunk has 2 existing findbugs issues Yetus then starts on it's second pass with the patch in place (the mvninstall lines are good indicators where it is). It then provides this output: +1 findbugs 0m 34s hadoop-common-project/hadoop-kms generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) .... which indicates the patch fixed the 2 findbugs issues.
          Hide
          xiaochen Xiao Chen added a comment -

          I see... It seems I misunderstood the pre-commit on addendum 1. That result was {{+1 findbugs 0m 32s the patch passed}}.. Sorry about that.

          Appreciate any reviews on addendum 2. (Is it required? Or is jenkins's +1 suffice here?)

          Show
          xiaochen Xiao Chen added a comment - I see... It seems I misunderstood the pre-commit on addendum 1. That result was {{+1 findbugs 0m 32s the patch passed}}.. Sorry about that. Appreciate any reviews on addendum 2. (Is it required? Or is jenkins's +1 suffice here?)
          Hide
          aw Allen Wittenauer added a comment -

          For the patched run, we can see this:

          No need to quote the console. It's in the JIRA message.

          Show
          aw Allen Wittenauer added a comment - For the patched run, we can see this: No need to quote the console. It's in the JIRA message.
          Hide
          xiaochen Xiao Chen added a comment -

          The pre-commit -1 is again on the trunk run. For the patched run, we can see this:

          ============================================================================
          ============================================================================
                                   findbugs detection: patch
          ============================================================================
          ============================================================================
          ....
          hadoop-common-project/hadoop-kms generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          

          So it should be fixed this time... Also verified via mvn compile findbugs:findbugs locally.

          Show
          xiaochen Xiao Chen added a comment - The pre-commit -1 is again on the trunk run. For the patched run, we can see this: ============================================================================ ============================================================================ findbugs detection: patch ============================================================================ ============================================================================ .... hadoop-common-project/hadoop-kms generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) So it should be fixed this time... Also verified via mvn compile findbugs:findbugs locally.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 8m 32s trunk passed
          +1 compile 8m 21s trunk passed
          +1 checkstyle 0m 13s trunk passed
          +1 mvnsite 0m 22s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          -1 findbugs 0m 26s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.
          +1 javadoc 0m 13s trunk passed
          +1 mvninstall 0m 18s the patch passed
          +1 compile 8m 16s the patch passed
          +1 javac 8m 16s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 0m 20s the patch passed
          +1 mvneclipse 0m 14s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 0m 34s hadoop-common-project/hadoop-kms generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 javadoc 0m 14s the patch passed
          +1 unit 2m 9s hadoop-kms in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          32m 38s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13669
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834877/trigger.02.patch
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux fd9ee21030dc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d0a3479
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10865/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10865/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10865/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 8m 32s trunk passed +1 compile 8m 21s trunk passed +1 checkstyle 0m 13s trunk passed +1 mvnsite 0m 22s trunk passed +1 mvneclipse 0m 13s trunk passed -1 findbugs 0m 26s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings. +1 javadoc 0m 13s trunk passed +1 mvninstall 0m 18s the patch passed +1 compile 8m 16s the patch passed +1 javac 8m 16s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 20s the patch passed +1 mvneclipse 0m 14s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 0m 34s hadoop-common-project/hadoop-kms generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 javadoc 0m 14s the patch passed +1 unit 2m 9s hadoop-kms in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 32m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13669 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834877/trigger.02.patch Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux fd9ee21030dc 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d0a3479 Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10865/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10865/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10865/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 47s trunk passed
          +1 compile 6m 56s trunk passed
          +1 checkstyle 0m 12s trunk passed
          +1 mvnsite 0m 19s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          -1 findbugs 0m 22s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.
          +1 javadoc 0m 12s trunk passed
          +1 mvninstall 0m 15s the patch passed
          +1 compile 6m 46s the patch passed
          +1 javac 6m 46s the patch passed
          +1 checkstyle 0m 12s the patch passed
          +1 mvnsite 0m 19s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 2s The patch has no ill-formed XML file.
          +1 findbugs 0m 29s hadoop-common-project/hadoop-kms generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2)
          +1 javadoc 0m 12s the patch passed
          +1 unit 2m 6s hadoop-kms in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          27m 38s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13669
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834877/trigger.02.patch
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 5d319aaeca96 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / d0a3479
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10866/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10866/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10866/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 47s trunk passed +1 compile 6m 56s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 12s trunk passed -1 findbugs 0m 22s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings. +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 15s the patch passed +1 compile 6m 46s the patch passed +1 javac 6m 46s the patch passed +1 checkstyle 0m 12s the patch passed +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 0m 29s hadoop-common-project/hadoop-kms generated 0 new + 0 unchanged - 2 fixed = 0 total (was 2) +1 javadoc 0m 12s the patch passed +1 unit 2m 6s hadoop-kms in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 27m 38s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13669 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12834877/trigger.02.patch Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 5d319aaeca96 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d0a3479 Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10866/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10866/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10866/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          Marking as patch available such that jenkins will trigger on this.

          Show
          brahmareddy Brahma Reddy Battula added a comment - Marking as patch available such that jenkins will trigger on this.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Brahma Reddy Battula for the report.... pretty weird I verified in intelliJ locally on addendum 1 and it passed. Pre-commit also seemed to agree...
          But yes now if I run mvn compile findbugs:findbugs it indeed reports the issue... Attaching an addendum2 patch to fix, also attaching a trigger patch since the fix along won't run the relevant pre-commit.

          Show
          xiaochen Xiao Chen added a comment - Thanks Brahma Reddy Battula for the report.... pretty weird I verified in intelliJ locally on addendum 1 and it passed. Pre-commit also seemed to agree... But yes now if I run mvn compile findbugs:findbugs it indeed reports the issue... Attaching an addendum2 patch to fix, also attaching a trigger patch since the fix along won't run the relevant pre-commit.
          Show
          brahmareddy Brahma Reddy Battula added a comment - Seems to findbugwarnings are still present. Please look the latest jenkins report. https://builds.apache.org/job/PreCommit-HADOOP-Build/10863/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/203/
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10609 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10609/)
          HADOOP-13669. Addendum patch for KMS Server should log exceptions before (xiao: rev ae51b11f7872eaac558acf00fd23f6d7b1841cfe)

          • (edit) hadoop-common-project/hadoop-kms/dev-support/findbugsExcludeFile.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10609 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10609/ ) HADOOP-13669 . Addendum patch for KMS Server should log exceptions before (xiao: rev ae51b11f7872eaac558acf00fd23f6d7b1841cfe) (edit) hadoop-common-project/hadoop-kms/dev-support/findbugsExcludeFile.xml
          Hide
          xiaochen Xiao Chen added a comment -

          Committed the addendum patch to the same branches. Thanks Wei-Chiu Chuang for the review and Allen Wittenauer for raising the issue.

          Show
          xiaochen Xiao Chen added a comment - Committed the addendum patch to the same branches. Thanks Wei-Chiu Chuang for the review and Allen Wittenauer for raising the issue.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Wei-Chiu Chuang! I'll commit end of today then.

          +1 on Yetus should improve on this.. I browsed through Yetus code but didn't find an easy way to fix this. Will create a jira.

          Show
          xiaochen Xiao Chen added a comment - Thanks Wei-Chiu Chuang ! I'll commit end of today then. +1 on Yetus should improve on this.. I browsed through Yetus code but didn't find an easy way to fix this. Will create a jira.
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Got it Xiao Chen
          The findbugs warning refers to trunk code, not the patch.

          cd /testptch/hadoop/hadoop-common-project/hadoop-kms
          mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-trunk-patch-0 -Ptest-patch -DskipTests test-compile findbugs:findbugs -DskipTests=true > /testptch/hadoop/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms.txt 2>&1
          Elapsed: 0m 23s

          hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.

          So Yetus should not flag findbugs warning in trunk. Probably worth an improvement.

          +1 from me. I'll leave it untouched until EOB in case Allen has additional comments.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Got it Xiao Chen The findbugs warning refers to trunk code, not the patch. cd /testptch/hadoop/hadoop-common-project/hadoop-kms mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-trunk-patch-0 -Ptest-patch -DskipTests test-compile findbugs:findbugs -DskipTests=true > /testptch/hadoop/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms.txt 2>&1 Elapsed: 0m 23s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings. So Yetus should not flag findbugs warning in trunk. Probably worth an improvement. +1 from me. I'll leave it untouched until EOB in case Allen has additional comments.
          Hide
          xiaochen Xiao Chen added a comment -

          Wei-Chiu Chuang thanks looking and kicking a rebuild.
          But as you can see from the history, addendum patch didn't trigger the pre-commit for the findbugs. So I added a trigger.patch identical to the addendum fix, plus a line break in KMS.java, so findbugs is run in pre-commit. As a result, findbugs is reporting the trunk version has 2 errors, while the patched version does not have any.

          Makes sense?

          Show
          xiaochen Xiao Chen added a comment - Wei-Chiu Chuang thanks looking and kicking a rebuild. But as you can see from the history, addendum patch didn't trigger the pre-commit for the findbugs. So I added a trigger.patch identical to the addendum fix, plus a line break in KMS.java, so findbugs is run in pre-commit. As a result, findbugs is reporting the trunk version has 2 errors, while the patched version does not have any. Makes sense?
          Hide
          jojochuang Wei-Chiu Chuang added a comment -

          Xiao Chen I triggered the rebuild but it picked up the trigger.patch, not the addendum.

          Show
          jojochuang Wei-Chiu Chuang added a comment - Xiao Chen I triggered the rebuild but it picked up the trigger.patch, not the addendum.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 37s trunk passed
          +1 compile 6m 53s trunk passed
          +1 checkstyle 0m 14s trunk passed
          +1 mvnsite 0m 21s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          -1 findbugs 0m 26s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.
          +1 javadoc 0m 11s trunk passed
          +1 mvninstall 0m 16s the patch passed
          +1 compile 8m 10s the patch passed
          +1 javac 8m 10s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 0m 19s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 0m 32s the patch passed
          +1 javadoc 0m 13s the patch passed
          +1 unit 2m 9s hadoop-kms in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          29m 3s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13669
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832943/trigger.patch
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 27fb6be82c73 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 12d739a
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10750/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10750/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10750/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 37s trunk passed +1 compile 6m 53s trunk passed +1 checkstyle 0m 14s trunk passed +1 mvnsite 0m 21s trunk passed +1 mvneclipse 0m 12s trunk passed -1 findbugs 0m 26s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings. +1 javadoc 0m 11s trunk passed +1 mvninstall 0m 16s the patch passed +1 compile 8m 10s the patch passed +1 javac 8m 10s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 0m 32s the patch passed +1 javadoc 0m 13s the patch passed +1 unit 2m 9s hadoop-kms in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 29m 3s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13669 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832943/trigger.patch Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 27fb6be82c73 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 12d739a Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10750/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10750/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10750/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -
          ============================================================================
                                   findbugs detection: trunk
          ============================================================================
          ...
          hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.
          
          ============================================================================
                                   findbugs detection: patch
          ============================================================================
          ============================================================================
          
          
          cd /testptch/hadoop/hadoop-common-project/hadoop-kms
          mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-trunk-patch-1 -Ptest-patch -DskipTests test-compile findbugs:findbugs -DskipTests=true > /testptch/hadoop/patchprocess/patch-findbugs-hadoop-common-project_hadoop-kms.txt 2>&1
          Elapsed:   0m 21s
          Starting with /testptch/hadoop/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.xml
          Merging /testptch/hadoop/patchprocess/patch-findbugs-hadoop-common-project_hadoop-kms-warnings.xml
          Writing /testptch/hadoop/patchprocess/combined-findbugs-hadoop-common-project_hadoop-kms.xml
          
          

          The addendum patch fixed the errors. I think this is ready for commit, Allen Wittenauer could you take a look? Thanks a lot.

          Show
          xiaochen Xiao Chen added a comment - ============================================================================ findbugs detection: trunk ============================================================================ ... hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings. ============================================================================ findbugs detection: patch ============================================================================ ============================================================================ cd /testptch/hadoop/hadoop-common-project/hadoop-kms mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hadoop-trunk-patch-1 -Ptest-patch -DskipTests test-compile findbugs:findbugs -DskipTests=true > /testptch/hadoop/patchprocess/patch-findbugs-hadoop-common-project_hadoop-kms.txt 2>&1 Elapsed: 0m 21s Starting with /testptch/hadoop/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.xml Merging /testptch/hadoop/patchprocess/patch-findbugs-hadoop-common-project_hadoop-kms-warnings.xml Writing /testptch/hadoop/patchprocess/combined-findbugs-hadoop-common-project_hadoop-kms.xml The addendum patch fixed the errors. I think this is ready for commit, Allen Wittenauer could you take a look? Thanks a lot.
          Hide
          sacharya Suraj Acharya added a comment -

          The patch looks good to me.
          Sorry about that Allen Wittenauer and Xiao Chen.

          Show
          sacharya Suraj Acharya added a comment - The patch looks good to me. Sorry about that Allen Wittenauer and Xiao Chen .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 39s trunk passed
          +1 compile 6m 49s trunk passed
          +1 checkstyle 0m 12s trunk passed
          +1 mvnsite 0m 18s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          -1 findbugs 0m 23s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings.
          +1 javadoc 0m 12s trunk passed
          +1 mvninstall 0m 16s the patch passed
          +1 compile 7m 22s the patch passed
          +1 javac 7m 22s the patch passed
          +1 checkstyle 0m 13s the patch passed
          +1 mvnsite 0m 19s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 0m 33s the patch passed
          +1 javadoc 0m 12s the patch passed
          +1 unit 2m 14s hadoop-kms in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          28m 6s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13669
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832943/trigger.patch
          Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux dddcca21f9d6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6476934
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10747/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10747/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10747/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 39s trunk passed +1 compile 6m 49s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 18s trunk passed +1 mvneclipse 0m 12s trunk passed -1 findbugs 0m 23s hadoop-common-project/hadoop-kms in trunk has 2 extant Findbugs warnings. +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 16s the patch passed +1 compile 7m 22s the patch passed +1 javac 7m 22s the patch passed +1 checkstyle 0m 13s the patch passed +1 mvnsite 0m 19s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 0m 33s the patch passed +1 javadoc 0m 12s the patch passed +1 unit 2m 14s hadoop-kms in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 28m 6s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13669 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832943/trigger.patch Optional Tests asflicense xml compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux dddcca21f9d6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6476934 Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10747/artifact/patchprocess/branch-findbugs-hadoop-common-project_hadoop-kms-warnings.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10747/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10747/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Let's trigger the findbugs check to be sure...

          Show
          xiaochen Xiao Chen added a comment - Let's trigger the findbugs check to be sure...
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 16s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 asflicense 0m 15s The patch does not generate ASF License warnings.
          0m 47s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13669
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832941/HADOOP-13669.addendum.patch
          Optional Tests asflicense xml
          uname Linux 9e48ebf421df 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 6476934
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10746/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 0m 47s Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13669 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832941/HADOOP-13669.addendum.patch Optional Tests asflicense xml uname Linux 9e48ebf421df 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 6476934 modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10746/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Allen Wittenauer for reporting this. Sorry for breaking things, I wasn't aware findbug reports have such a severe consequence...

          Attaching the addendum. Suraj Acharya, could you take a look?

          Show
          xiaochen Xiao Chen added a comment - Thanks Allen Wittenauer for reporting this. Sorry for breaking things, I wasn't aware findbug reports have such a severe consequence... Attaching the addendum. Suraj Acharya , could you take a look?
          Hide
          aw Allen Wittenauer added a comment -

          Findbugs warnings are false alarm, since the exception is thrown.

          ...

          Committed this to trunk, branch-2 and branch-2.8.

          Re-opening, because this patch needs an addendum. Please don't commit patches that throw findbugs errors.

          If you are sure this is a false alarm, an exception must get added to findbugs-exclude.xml. Until that happens, the release, the nightlies, and all other patches against hadoop-kms are going to fail.

          Show
          aw Allen Wittenauer added a comment - Findbugs warnings are false alarm, since the exception is thrown. ... Committed this to trunk, branch-2 and branch-2.8. Re-opening, because this patch needs an addendum. Please don't commit patches that throw findbugs errors. If you are sure this is a false alarm, an exception must get added to findbugs-exclude.xml. Until that happens, the release, the nightlies, and all other patches against hadoop-kms are going to fail.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10580 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10580/)
          HADOOP-13669. KMS Server should log exceptions before throwing. (xiao: rev 65912e4027548868ebefd8ee36eb00fa889704a7)

          • (edit) hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10580 (See https://builds.apache.org/job/Hadoop-trunk-Commit/10580/ ) HADOOP-13669 . KMS Server should log exceptions before throwing. (xiao: rev 65912e4027548868ebefd8ee36eb00fa889704a7) (edit) hadoop-common-project/hadoop-kms/src/main/java/org/apache/hadoop/crypto/key/kms/server/KMS.java
          Hide
          xiaochen Xiao Chen added a comment -

          Committed this to trunk, branch-2 and branch-2.8.
          Thanks Suraj Acharya for the contribution!

          Show
          xiaochen Xiao Chen added a comment - Committed this to trunk, branch-2 and branch-2.8. Thanks Suraj Acharya for the contribution!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 6m 32s trunk passed
          +1 compile 6m 49s trunk passed
          +1 checkstyle 0m 12s trunk passed
          +1 mvnsite 0m 18s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 22s trunk passed
          +1 javadoc 0m 12s trunk passed
          +1 mvninstall 0m 15s the patch passed
          +1 compile 6m 40s the patch passed
          +1 javac 6m 40s the patch passed
          +1 checkstyle 0m 12s hadoop-common-project/hadoop-kms: The patch generated 0 new + 1 unchanged - 5 fixed = 1 total (was 6)
          +1 mvnsite 0m 18s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 30s hadoop-common-project/hadoop-kms generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          +1 javadoc 0m 12s the patch passed
          +1 unit 2m 7s hadoop-kms in the patch passed.
          +1 asflicense 0m 20s The patch does not generate ASF License warnings.
          27m 4s



          Reason Tests
          FindBugs module:hadoop-common-project/hadoop-kms
            Exception is caught when Exception is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.createKey(Map) At KMS.java:is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.createKey(Map) At KMS.java:[line 169]
            Exception is caught when Exception is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.generateEncryptedKeys(String, String, int) At KMS.java:is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.generateEncryptedKeys(String, String, int) At KMS.java:[line 501]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13669
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832278/HADOOP-13369.2.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 3e178d2b9a67 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 4d10621
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10713/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-kms.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10713/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10713/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 6m 32s trunk passed +1 compile 6m 49s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 18s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 22s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 15s the patch passed +1 compile 6m 40s the patch passed +1 javac 6m 40s the patch passed +1 checkstyle 0m 12s hadoop-common-project/hadoop-kms: The patch generated 0 new + 1 unchanged - 5 fixed = 1 total (was 6) +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 30s hadoop-common-project/hadoop-kms generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 0m 12s the patch passed +1 unit 2m 7s hadoop-kms in the patch passed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 27m 4s Reason Tests FindBugs module:hadoop-common-project/hadoop-kms   Exception is caught when Exception is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.createKey(Map) At KMS.java:is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.createKey(Map) At KMS.java: [line 169]   Exception is caught when Exception is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.generateEncryptedKeys(String, String, int) At KMS.java:is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.generateEncryptedKeys(String, String, int) At KMS.java: [line 501] Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13669 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832278/HADOOP-13369.2.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 3e178d2b9a67 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 4d10621 Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10713/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-kms.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10713/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10713/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sacharya Suraj Acharya added a comment -

          Fixed human checkstyle issues!

          Thanks Xiao Chen.

          Show
          sacharya Suraj Acharya added a comment - Fixed human checkstyle issues! Thanks Xiao Chen .
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks Suraj Acharya for revving. Looks good to me. We're just logging a debug log on any exception before throwing. This would make debugging problems a lot easier while not have much impact on normal usages.

          Findbugs warnings are false alarm, since the exception is thrown.
          +1 pending the below to nits (I'm the human checkstyle wizard):

          • Line 198: s/} catch (Exception e){/} catch (Exception e) {/g
          • Line 282: s/}catch (Exception e) {/} catch (Exception e) {/g
          Show
          xiaochen Xiao Chen added a comment - Thanks Suraj Acharya for revving. Looks good to me. We're just logging a debug log on any exception before throwing. This would make debugging problems a lot easier while not have much impact on normal usages. Findbugs warnings are false alarm, since the exception is thrown. +1 pending the below to nits (I'm the human checkstyle wizard): Line 198: s/ } catch (Exception e){ / } catch (Exception e) { /g Line 282: s/ }catch (Exception e) { / } catch (Exception e) { /g
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
          0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 9m 12s trunk passed
          +1 compile 9m 1s trunk passed
          +1 checkstyle 0m 15s trunk passed
          +1 mvnsite 0m 23s trunk passed
          +1 mvneclipse 0m 15s trunk passed
          +1 findbugs 0m 29s trunk passed
          +1 javadoc 0m 14s trunk passed
          +1 mvninstall 0m 18s the patch passed
          +1 compile 9m 13s the patch passed
          +1 javac 9m 13s the patch passed
          +1 checkstyle 0m 13s hadoop-common-project/hadoop-kms: The patch generated 0 new + 1 unchanged - 5 fixed = 1 total (was 6)
          +1 mvnsite 0m 21s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 50s hadoop-common-project/hadoop-kms generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          +1 javadoc 0m 12s the patch passed
          +1 unit 2m 14s hadoop-kms in the patch passed.
          +1 asflicense 0m 26s The patch does not generate ASF License warnings.
          35m 41s



          Reason Tests
          FindBugs module:hadoop-common-project/hadoop-kms
            Exception is caught when Exception is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.createKey(Map) At KMS.java:is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.createKey(Map) At KMS.java:[line 169]
            Exception is caught when Exception is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.generateEncryptedKeys(String, String, int) At KMS.java:is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.generateEncryptedKeys(String, String, int) At KMS.java:[line 501]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13669
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832190/HADOOP-13369.patch.1
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b704f8164ac0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 3565c9a
          Default Java 1.8.0_101
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10702/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-kms.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10702/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10702/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated. 0 patch 0m 1s The patch file was not named according to hadoop's naming conventions. Please see https://wiki.apache.org/hadoop/HowToContribute for instructions. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 9m 12s trunk passed +1 compile 9m 1s trunk passed +1 checkstyle 0m 15s trunk passed +1 mvnsite 0m 23s trunk passed +1 mvneclipse 0m 15s trunk passed +1 findbugs 0m 29s trunk passed +1 javadoc 0m 14s trunk passed +1 mvninstall 0m 18s the patch passed +1 compile 9m 13s the patch passed +1 javac 9m 13s the patch passed +1 checkstyle 0m 13s hadoop-common-project/hadoop-kms: The patch generated 0 new + 1 unchanged - 5 fixed = 1 total (was 6) +1 mvnsite 0m 21s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 50s hadoop-common-project/hadoop-kms generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 0m 12s the patch passed +1 unit 2m 14s hadoop-kms in the patch passed. +1 asflicense 0m 26s The patch does not generate ASF License warnings. 35m 41s Reason Tests FindBugs module:hadoop-common-project/hadoop-kms   Exception is caught when Exception is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.createKey(Map) At KMS.java:is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.createKey(Map) At KMS.java: [line 169]   Exception is caught when Exception is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.generateEncryptedKeys(String, String, int) At KMS.java:is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.generateEncryptedKeys(String, String, int) At KMS.java: [line 501] Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13669 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12832190/HADOOP-13369.patch.1 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b704f8164ac0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 3565c9a Default Java 1.8.0_101 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10702/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-kms.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10702/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10702/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sacharya Suraj Acharya added a comment -
          • Fixed Checkstyle.
          • Made the error messages to be debug level
          Show
          sacharya Suraj Acharya added a comment - Fixed Checkstyle. Made the error messages to be debug level
          Hide
          xiaochen Xiao Chen added a comment -

          I agree those errors usually indicate a problem. But my concern is that, assuming we have 1 problematic key which throws exceptions, we may end up seeing that key log a bunch of stacktraces, hence spamming the log and also impacting server performance. Making it debug can give us more control (e.g. choose to temporarily turn it on on 1 KMS instance etc.)

          Show
          xiaochen Xiao Chen added a comment - I agree those errors usually indicate a problem. But my concern is that, assuming we have 1 problematic key which throws exceptions, we may end up seeing that key log a bunch of stacktraces, hence spamming the log and also impacting server performance. Making it debug can give us more control (e.g. choose to temporarily turn it on on 1 KMS instance etc.)
          Hide
          sacharya Suraj Acharya added a comment -

          I agree with the logic of it being a bit too much.
          However, my thought process was that since most of these errors will be a fatal error (either killing the operation in progress / killing the startup of the KMS) i thought it was worth putting this as an error message.
          But ill take whatever recommendation you'll give me on this one.

          Show
          sacharya Suraj Acharya added a comment - I agree with the logic of it being a bit too much. However, my thought process was that since most of these errors will be a fatal error (either killing the operation in progress / killing the startup of the KMS) i thought it was worth putting this as an error message. But ill take whatever recommendation you'll give me on this one.
          Hide
          xiaochen Xiao Chen added a comment -

          Thanks for working on this Suraj Acharya. I know this is still in the works, but propose to only log the exception stack trace in debug, to prevent spamming the server logs and unnecessary performance impact.
          One way to do that is to log a higher level message without the stack trace, and then log a DEBUG with stacktrace. But since we can already see the error from client side, maybe just DEBUG logging the message + stack trace is fine.

          Also ping Arun Suresh for his input.

          Show
          xiaochen Xiao Chen added a comment - Thanks for working on this Suraj Acharya . I know this is still in the works, but propose to only log the exception stack trace in debug, to prevent spamming the server logs and unnecessary performance impact. One way to do that is to log a higher level message without the stack trace, and then log a DEBUG with stacktrace. But since we can already see the error from client side, maybe just DEBUG logging the message + stack trace is fine. Also ping Arun Suresh for his input.
          Hide
          sacharya Suraj Acharya added a comment -

          Seems like i have hit a bunch of lines which hadnt been touched in a while.
          Ill work on that now.

          Show
          sacharya Suraj Acharya added a comment - Seems like i have hit a bunch of lines which hadnt been touched in a while. Ill work on that now.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 23s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
          +1 mvninstall 7m 3s trunk passed
          +1 compile 7m 6s trunk passed
          +1 checkstyle 0m 12s trunk passed
          +1 mvnsite 0m 19s trunk passed
          +1 mvneclipse 0m 12s trunk passed
          +1 findbugs 0m 23s trunk passed
          +1 javadoc 0m 12s trunk passed
          +1 mvninstall 0m 16s the patch passed
          +1 compile 6m 58s the patch passed
          +1 javac 6m 58s the patch passed
          -0 checkstyle 0m 12s hadoop-common-project/hadoop-kms: The patch generated 48 new + 1 unchanged - 5 fixed = 49 total (was 6)
          +1 mvnsite 0m 18s the patch passed
          +1 mvneclipse 0m 13s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 findbugs 0m 32s hadoop-common-project/hadoop-kms generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
          +1 javadoc 0m 12s the patch passed
          +1 unit 2m 6s hadoop-kms in the patch passed.
          +1 asflicense 0m 21s The patch does not generate ASF License warnings.
          28m 25s



          Reason Tests
          FindBugs module:hadoop-common-project/hadoop-kms
            Exception is caught when Exception is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.createKey(Map) At KMS.java:is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.createKey(Map) At KMS.java:[line 169]
            Exception is caught when Exception is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.generateEncryptedKeys(String, String, int) At KMS.java:is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.generateEncryptedKeys(String, String, int) At KMS.java:[line 501]



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:9560f25
          JIRA Issue HADOOP-13669
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831230/HADOOP-13369.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9b39b637268b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fe9ebe2
          Default Java 1.8.0_101
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10638/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-kms.txt
          findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10638/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-kms.html
          Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10638/testReport/
          modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms
          Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10638/console
          Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 23s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 mvninstall 7m 3s trunk passed +1 compile 7m 6s trunk passed +1 checkstyle 0m 12s trunk passed +1 mvnsite 0m 19s trunk passed +1 mvneclipse 0m 12s trunk passed +1 findbugs 0m 23s trunk passed +1 javadoc 0m 12s trunk passed +1 mvninstall 0m 16s the patch passed +1 compile 6m 58s the patch passed +1 javac 6m 58s the patch passed -0 checkstyle 0m 12s hadoop-common-project/hadoop-kms: The patch generated 48 new + 1 unchanged - 5 fixed = 49 total (was 6) +1 mvnsite 0m 18s the patch passed +1 mvneclipse 0m 13s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. -1 findbugs 0m 32s hadoop-common-project/hadoop-kms generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0) +1 javadoc 0m 12s the patch passed +1 unit 2m 6s hadoop-kms in the patch passed. +1 asflicense 0m 21s The patch does not generate ASF License warnings. 28m 25s Reason Tests FindBugs module:hadoop-common-project/hadoop-kms   Exception is caught when Exception is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.createKey(Map) At KMS.java:is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.createKey(Map) At KMS.java: [line 169]   Exception is caught when Exception is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.generateEncryptedKeys(String, String, int) At KMS.java:is not thrown in org.apache.hadoop.crypto.key.kms.server.KMS.generateEncryptedKeys(String, String, int) At KMS.java: [line 501] Subsystem Report/Notes Docker Image:yetus/hadoop:9560f25 JIRA Issue HADOOP-13669 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12831230/HADOOP-13369.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9b39b637268b 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fe9ebe2 Default Java 1.8.0_101 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HADOOP-Build/10638/artifact/patchprocess/diff-checkstyle-hadoop-common-project_hadoop-kms.txt findbugs https://builds.apache.org/job/PreCommit-HADOOP-Build/10638/artifact/patchprocess/new-findbugs-hadoop-common-project_hadoop-kms.html Test Results https://builds.apache.org/job/PreCommit-HADOOP-Build/10638/testReport/ modules C: hadoop-common-project/hadoop-kms U: hadoop-common-project/hadoop-kms Console output https://builds.apache.org/job/PreCommit-HADOOP-Build/10638/console Powered by Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          sacharya Suraj Acharya added a comment -

          Initial draft

          Show
          sacharya Suraj Acharya added a comment - Initial draft

            People

            • Assignee:
              sacharya Suraj Acharya
              Reporter:
              xiaochen Xiao Chen
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development