[YARN-9124] Resolve contradiction in ResourceUtils: addMandatoryResources / checkMandatoryResources work differently

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.3.0, 3.2.1, 3.1.3
• Hadoop Flags: Reviewed
• Assignee: Adam Antal
• Reporter: Szilard Nemeth
• Created: 14/Dec/18 11:21
• Updated: 09/Aug/19 09:45
• Resolved: 09/Aug/19 09:45

Description

ResourceUtils#addMandatoryResources: Adds only memory and vcores as mandatory resources.

ResourceUtils#checkMandatoryResources: YARN-6620 added some code to this. This method not only checks memory and vcores, but all the resources referred in ResourceInformation#MANDATORY_RESOURCES.

I think it would be good to call MANDATORY_RESOURCES as PREDEFINED_RESOURCES or something like that and use a similar name for checkMandatoryResources.

Issue Links

• links to: GitHub Pull Request #1121