Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-9124

Resolve contradiction in ResourceUtils: addMandatoryResources / checkMandatoryResources work differently

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0, 3.2.1, 3.1.3
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      ResourceUtils#addMandatoryResources: Adds only memory and vcores as mandatory resources.

      ResourceUtils#checkMandatoryResources: YARN-6620 added some code to this. This method not only checks memory and vcores, but all the resources referred in ResourceInformation#MANDATORY_RESOURCES.

      I think it would be good to call MANDATORY_RESOURCES as PREDEFINED_RESOURCES or something like that and use a similar name for checkMandatoryResources.

        Attachments

        1. YARN-9124.branch-3.1.001.patch
          5 kB
          Adam Antal
        2. YARN-9124.branch-3.2.001.patch
          5 kB
          Adam Antal
        3. YARN-9124.branch-3.2.001.patch
          5 kB
          Adam Antal

          Issue Links

            Activity

              People

              • Assignee:
                adam.antal Adam Antal
                Reporter:
                snemeth Szilard Nemeth
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: