[YARN-894] NodeHealthScriptRunner timeout checking is inaccurate on Windows

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.1.0-beta, 3.0.0-alpha1
• Fix Version/s: 2.1.0-beta
• Component/s: nodemanager
• Target Version/s: 2.1.0-beta
• Hadoop Flags: Reviewed
• Assignee: Chuan Liu
• Reporter: Chuan Liu
• Created: 02/Jul/13 01:07
• Updated: 12/May/16 18:29
• Resolved: 08/Jul/13 23:54

Description

In NodeHealthScriptRunner method, we will set HealthChecker status based on the Shell execution results. Some status are based on the exception thrown during the Shell script execution.

Currently, we will catch a non-ExitCodeException from ShellCommandExecutor, and if Shell has the timeout status set at the same time, we will also set HealthChecker status to timeout.

We have following execution sequence in Shell:
1) In main thread, schedule a delayed timer task that will kill the original process upon timeout.
2) In main thread, open a buffered reader and feed in the process's standard input stream.
3) When timeout happens, the timer task will call Process#destroy()
to kill the main process.

On Linux, when timeout happened and process killed, the buffered reader will thrown an IOException with message: "Stream closed" in main thread.

On Windows, we don't have the IOException. Only "-1" was returned from the reader that indicates the buffer is finished. As a result, the timeout status is not set on Windows, and TestNodeHealthService fails on Windows because of this.

Issue Links

• is part of: YARN-191 Enhancements to YARN for Windows Server and Windows Azure development and runtime environments